feat(mobile): stable native build keys and CI-offloaded native builds - #5629
Merged
Conversation
Native build caches almost never hit: hashRootNativeInputs hashes all of pnpm-lock.yaml, so every dependency change anywhere in the monorepo re-keys mobile native builds whose inputs did not change. The machine cache held 15 Android entries under 15 distinct keys, with byte-identical APKs stored under different keys, and 23 iOS producer locks with 23 distinct keys. - Hash only the apps/mobile importer block of pnpm-lock.yaml. The block pins the full resolved versions of every direct dependency, which is what autolinking can see. Fall back to the whole file when the block is missing. - Pin the generated ios/ and android/ trees out of the fingerprint with ignorePaths. The current @expo/fingerprint already excludes them; the pin keeps any future version from keying builds on generated output. - Add .github/workflows/mobile-native-build.yml: build the debug dev-client on CI and upload it as an artifact named mobile-native-<platform>-<nativeHash>. Runs on main pushes that can change native inputs and on workflow_dispatch for any pushed branch. A gate job skips platforms whose artifact already exists, and the iOS job fails if the hash differs between Linux and macOS. - On a local cache miss, fetch that artifact (and dispatch a build for the current pushed branch when none exists) before compiling locally. The fetched app passes the existing publish pipeline: bundle-id check, checksum, manifest, atomic rename. Any remote failure falls back to the local build. Set KILO_REMOTE_NATIVE=off to disable.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous Review Summaries (4 snapshots, latest commit 672e68d)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 672e68d)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous review (commit 984e620)Status: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Previous review (commit 4d7632b)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous review (commit 6d675cc)Status: 3 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)CRITICAL
WARNING
Files Reviewed (10 files)
Reviewed by grok-4.6 · Input: 98.2K · Output: 7.6K · Cached: 174.1K Review guidance: REVIEW.md from base branch |
… run Review follow-ups on the native build offload: - A pull_request run of mobile-native-build now always builds both platforms and uploads under a pr<N>- artifact prefix. Before, the gate saw the main artifact for the same nativeHash and skipped every job, so the self-validation validated nothing; on a miss it published into the namespace hosts install from. - The dispatch watcher now takes the newest run that did not exist before the dispatch and that matches HEAD, instead of the newest run created within a two-minute window. The old window could attach to another host's concurrent dispatch or to a run that started before this one.
Three follow-ups on the native build offload: - The iOS artifact now carries a toolchain.json with the Xcode build version and simulator SDK that produced it, and the fetcher refuses an artifact whose toolchain differs from the host's. The artifact name keys on nativeHash alone, but the local cache key also keys on the toolchain, so a host used to publish a runner-built .app under its own key. When the runner's simulator SDK is newer than the host's runtime, that app never launches, and the entry sticks under a key the host keeps recomputing. It now falls back to a local build instead. - The macOS job checks the android nativeHash against the gate as well as the iOS one. Android builds on Linux but is consumed on macOS, and a divergence there would make every android fetch miss in silence. - The dispatch path logs how long it waited on CI. Waiting only pays while it stays under a local compile; log it so that stays measurable.
A pull_request build validates the workflow and its artifact is scoped to the PR, so a superseded one must not hold a macOS runner. A push build produces an artifact hosts install, so it still runs to completion.
The pull_request gate forced both platform builds on every push, so each commit to a workflow-editing PR spent a macOS runner it did not need. Key the PR artifact on the workflow file as well as the PR number and let the normal exists() check decide: the first push of a given workflow version builds, a re-push of the same file skips, and an edit builds again. PR artifacts now expire after a day, since only a push build is installed.
setup-java v4 is deprecated, and both it and upload-artifact v5 target Node 20, which the runner now forces onto Node 24. Bump to setup-java v5.7.0 and upload-artifact v7.0.1, both runs.using: node24. v7.0.1 is already used elsewhere in this repo. Neither changes the inputs used here; both need runner 2.327.1 or newer, which GitHub-hosted satisfies.
RSO
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
The machine-global native build caches almost never hit. Evidence from the e2e host:
Cause
hashRootNativeInputshashes all ofpnpm-lock.yaml. The lockfile changed in 14 commits over the last 14 days, so any dependency change anywhere in the monorepo re-keys mobile native builds whose inputs did not change. (The generatedios//androidtrees were checked and are not part of the hash — the earlier prebuild-tree-cache diagnosis attributed the churn to them, but@expo/fingerprintnever included them.)Fix
apps/mobileimporter block ofpnpm-lock.yaml. The block pins the full resolved versions of every direct dependency, which is exactly what autolinking can see. A missing block falls back to the whole file. Pinios/**/android/**out of the fingerprint so no future@expo/fingerprintversion can key builds on generated output.mobile-native-build.ymlbuilds the debug dev-client and uploads it as an artifact namedmobile-native-<platform>-<nativeHash>. It runs on main pushes that can change native inputs and onworkflow_dispatchfor any pushed branch. A gate job skips platforms whose artifact already exists; the iOS job fails if the hash differs between Linux and macOS (a divergence would publish artifacts nobody can find).dev:mobile:{ios,android} buildnow downloads that artifact — and dispatches a run for the current pushed branch when none exists — before compiling locally. The fetched binary passes the existing publish pipeline unchanged: bundle-id/package-id check, checksum, manifest, atomic rename. Any remote failure falls back to today's local build.KILO_REMOTE_NATIVE=offdisables it.Why this matters
A native build is the expensive part of an e2e slot; installing a cached binary is cheap. With stable keys plus CI-built artifacts, agent hosts stop paying local xcodebuild/gradle for unchanged native inputs, which frees CPU for more concurrent e2e slots.
Tests
pnpm run test:mobile-workflow— 104 pass (new: remote-fetch publish path, remote-miss fallback, lockfile-slice keying).apps/mobileimporter changes do.dev/local/tmux.test.tshas one pre-existing failure on this host on cleanorigin/main(timing-sensitive; unrelated).