Skip to content

fix(mobile): harden agent workflow and E2E reliability#4593

Merged
iscekic merged 7 commits into
mainfrom
chore/mobile-planner-modes
Jul 16, 2026
Merged

fix(mobile): harden agent workflow and E2E reliability#4593
iscekic merged 7 commits into
mainfrom
chore/mobile-planner-modes

Conversation

@iscekic

@iscekic iscekic commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add hands-on and hands-off planning modes with an independently verified plan-review gate
  • allow tightly scoped temporary verifier fixtures, require (bot) GitHub comments, and remove brittle .kilo prose tests
  • handle the iOS external-app prompt, keep implicit E2E claims on iPhones, and avoid unused Android IAP initialization

Verification

  • pnpm test:mobile-workflow (209 passed)
  • pnpm --filter kilo-app test (843 passed)
  • pnpm --filter kilo-app typecheck
  • pnpm --filter kilo-app lint
  • pnpm --filter kilo-app check:unused
  • pnpm --filter kilo-app format:check
  • kilo config check
  • maestro check-syntax apps/mobile/e2e/flows/open-app.yaml
  • maestro check-syntax apps/mobile/e2e/flows/settle-app.yaml

Device evidence

  • implicit iOS claim selected an iPhone 17e simulator rather than an iPad
  • external-app prompt could not be freshly reproduced because Safari did not show the alert on the claimed simulator; executable flow contracts and Maestro syntax cover the handler
  • no unowned Android emulator was connected, so Android IAP behavior is covered by platform-gate tests rather than a fresh device run

@iscekic iscekic self-assigned this Jul 16, 2026
@kilo-code-bot

kilo-code-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of the two new commits found only documentation dedup/rewording of the mobile agent workflow, runbook, and E2E-verifier prose plus a consistent test refactor to match the simplified open-app.yamlsettle-app.yaml split; no bugs, security issues, or logic errors in changed code.

Files Reviewed (9 files)
  • apps/mobile/.kilo/MOBILE_WORKFLOW.md
  • apps/mobile/.kilo/agent/mobile-e2e-verifier.md
  • apps/mobile/.kilo/agent/mobile-implementer.md
  • apps/mobile/e2e/AGENTS.md
  • apps/mobile/e2e/flows/login-request-code.yaml
  • apps/mobile/e2e/flows/open-app.yaml
  • apps/mobile/e2e/flows/settle-app.yaml
  • apps/mobile/e2e/logout.sh
  • dev/local/mobile-workflow.test.ts
Previous Review Summaries (2 snapshots, latest commit a5853fc)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit a5853fc)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of the single new commit found only a documentation-policy tweak to the base-branch integration step in MOBILE_WORKFLOW.md; no bugs, security issues, or logic errors in changed code.

Files Reviewed (1 file)
  • apps/mobile/.kilo/MOBILE_WORKFLOW.md

Previous review (commit 06c91fe)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed workflow/agent doc updates, Maestro flow changes for the iOS external-app prompt, iPhone-preferring simulator claim logic, and the Android IAP no-op provider split; no high-confidence bugs, security issues, or logic errors found in changed code.

Files Reviewed (11 files)
  • apps/mobile/.kilo/MOBILE_WORKFLOW.md
  • apps/mobile/.kilo/agent/mobile-e2e-verifier.md
  • apps/mobile/.kilo/agent/mobile-plan-reviewer.md
  • apps/mobile/e2e/flows/open-app.yaml
  • apps/mobile/e2e/flows/settle-app.yaml
  • apps/mobile/src/lib/kilo-pass/use-store-kilo-pass-purchase.test.tsx
  • apps/mobile/src/lib/kilo-pass/use-store-kilo-pass-purchase.ts
  • dev/local/mobile-simulator.test.ts
  • dev/local/mobile-simulator.ts
  • dev/local/mobile-workflow.test.ts

Reviewed by claude-sonnet-5 · Input: 40 · Output: 6.5K · Cached: 1M

Review guidance: REVIEW.md from base branch main

@iscekic iscekic merged commit 128a760 into main Jul 16, 2026
20 checks passed
@iscekic iscekic deleted the chore/mobile-planner-modes branch July 16, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants