fix(privacy): remove exposed email data#2352
Merged
jeanduplessis merged 6 commits intomainfrom May 7, 2026
Merged
Conversation
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)No additional issues found outside the current PR diff. Files Reviewed (7 files)
Reviewed by gpt-5.5-20260423 · 1,757,341 tokens |
feb3246 to
5ad8a9b
Compare
jrf0110
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code-related pentest L2 email-exposure guardrails are tightened while preserving client-side conversion matching through hashed identifiers.
emailandnamevalues with normalized, unsalted SHA-256 hashes for authenticated users.email_sha256,name_sha256, anduser_data_format: "sha256"dataLayer fields so downstream tags can distinguish the hashed contract.CONTRIBUTOR_CHAMPION_TEAM_EMAILSso source no longer stores personal email literals.mail.example.comandfoo.bar.example.co.ukso tests block real personal email literals without rejecting common fixtures.Verification
N/A — no manual UI verification; this is a code/test-only privacy guardrail change.
Visual Changes
N/A
Reviewer Notes
emailandnamekeys are intentionally retained for the existing container variables, but now contain SHA-256 hashes rather than raw values.CONTRIBUTOR_CHAMPION_TEAM_EMAILSfor non-domain team emails that must stay excluded from contributor champion eligibility.