Add glTF-KTX-BasisU variant for FlightHelmet - #270
Conversation
b5a6711 to
a821cc4
Compare
There was a problem hiding this comment.
Pull request overview
Adds a KTX2/BasisU-compressed variant of the FlightHelmet sample asset and registers it in the model indices, along with documentation describing the conversion and resulting texture size changes.
Changes:
- Register a new
glTF-KTX-BasisUvariant forFlightHelmetin bothmodel-index.jsonandmodel-index.Khronos.json. - Add documentation to
Models/FlightHelmet/README.body.mddescribing the KTX2/BasisU pipeline and texture size deltas. - Add a new
Models/FlightHelmet/glTF-KTX-BasisU/asset variant (gltf + KTX2 textures).
Reviewed changes
Copilot reviewed 3 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Models/model-index.Khronos.json | Adds glTF-KTX-BasisU variant entry for FlightHelmet in the Khronos index. |
| Models/model-index.json | Adds glTF-KTX-BasisU variant entry for FlightHelmet in the main index. |
| Models/FlightHelmet/README.body.md | Documents the new KTX2/BasisU variant and texture size reductions. |
| Models/FlightHelmet/glTF-KTX-BasisU/FlightHelmet.gltf | New glTF variant referencing KTX2 textures via KHR_texture_basisu. |
| Models/FlightHelmet/glTF-KTX-BasisU/FlightHelmet_Materials_LensesMat_Normal.ktx2 | Adds one of the KTX2 texture assets used by the new variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a821cc4 to
28133c6
Compare
Regenerated KTX2/Basis Universal compressed textures from the original FlightHelmet glTF using glTF-Transform v4.3.0 (ETC1S for baseColor, UASTC for non-color). This preserves all extensions including KHR_materials_transmission on LensesMat. Updated README.body.md with texture size comparison table. README.md will be regenerated by CI. Closes KhronosGroup#169
28133c6 to
1de0f8e
Compare
There was a problem hiding this comment.
Pull request overview
Adds a KTX2/BasisU-compressed glTF variant for the FlightHelmet sample model and wires it into the model index, along with documentation about the conversion and size impact.
Changes:
- Register a new
glTF-KTX-BasisUvariant forFlightHelmetinModels/model-index.json. - Extend
Models/FlightHelmet/README.body.mdwith details on the KTX2/BasisU workflow and size comparison. - Add a new
Models/FlightHelmet/glTF-KTX-BasisU/asset package (gltf + bin + KTX2 textures) usingKHR_texture_basisu.
Reviewed changes
Copilot reviewed 3 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Models/model-index.json | Adds glTF-KTX-BasisU variant entry for the FlightHelmet model. |
| Models/FlightHelmet/README.body.md | Documents the KTX2/BasisU variant and provides size comparisons and tooling commands. |
| Models/FlightHelmet/glTF-KTX-BasisU/FlightHelmet.gltf | New glTF variant referencing KTX2 textures via KHR_texture_basisu. |
| Models/FlightHelmet/glTF-KTX-BasisU/FlightHelmet_Materials_LensesMat_Normal.ktx2 | New KTX2 texture asset (BasisU-compressed). |
| Models/FlightHelmet/glTF-KTX-BasisU/FlightHelmet_Materials_LensesMat_BaseColor.ktx2 | New KTX2 texture asset (BasisU-compressed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Given that BabylonJS/Assets#136 is already merged, I assume that this could also be merged? |
This is unrelated. We usually copy the same asset here into our assets repo to avoid using GitHub raw URLs for testing.
It would be great to get a second pair of eyes on the model before merge. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
I dragged-and-dropped the model into https://gltf-viewer.donmccurdy.com/ and it worked. And even at the risk of you thinking: "Is he ... kidding me?!": Yes, I also dragged-and-dropped it into https://sandbox.babylonjs.com/ and it worked 😁 The overall asset size was reduced from ~46MB to 32MB. More importantly: The VRAM size (as claimed by https://gltf.report/ ) was reduced from ~288MB to ~63MB. I checked all files with |
Add KTX2/Basis Universal compressed texture variant for the FlightHelmet model, copied from glTF-Sample-Models but regenerated using latest glTF-Transform. Updated model-index.json to include the new variant.
Closes #169