sync: Introduce command objects for validation - #12936
Merged
artem-lunarg merged 1 commit intoAug 25, 2026
Merged
Conversation
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 90003. |
Collaborator
|
CI Vulkan-ValidationLayers build # 24246 running. |
artem-lunarg
commented
Aug 25, 2026
| using const_pointer = T const *; | ||
| using iterator = Iterator; | ||
| using const_iterator = const Iterator; | ||
| using value_type = std::remove_cv_t<T>; |
Contributor
Author
There was a problem hiding this comment.
This is to make vvl::enumerate work with vvl::span
artem-lunarg
marked this pull request as ready for review
August 25, 2026 13:20
spencer-lunarg
approved these changes
Aug 25, 2026
Move vkCmdCopyBuffer record-time validation into BufferCopyCommand. Introduce initial design concepts that are not used yet. BufferCopyCommand::Storage is a compact representation of the command. It will be stored during command buffer recording. The validation itself works with full BufferCopyCommand. CommandData stores variable-sized data and avoids per-command allocations and can support deduplication if needed.
artem-lunarg
force-pushed
the
artem-sync-command-buffer-copy
branch
from
August 25, 2026 13:53
6e33b2a to
610f836
Compare
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 90079. |
artem-lunarg
changed the title
Collaborator
|
CI Vulkan-ValidationLayers build # 24250 running. |
Collaborator
|
CI Vulkan-ValidationLayers build # 24250 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move vkCmdCopyBuffer record-time validation into BufferCopyCommand.
Introduce initial design concepts that are not used yet.
BufferCopyCommand::Storage is a compact representation of the command. It will be stored during command buffer recording. The validation itself works with full BufferCopyCommand.
CommandData stores variable-sized data and avoids per-command allocations and can support deduplication if needed.