Skip to content

layers: Handle GPL with DynamicRendering and InputAttachment - #12911

Merged
spencer-lunarg merged 1 commit into
KhronosGroup:mainfrom
spencer-lunarg:spencer-lunarg-i-think-gpl-could-be-a-good-extension-if-you-first-deleted-it-from-the-world
Aug 25, 2026
Merged

layers: Handle GPL with DynamicRendering and InputAttachment#12911
spencer-lunarg merged 1 commit into
KhronosGroup:mainfrom
spencer-lunarg:spencer-lunarg-i-think-gpl-could-be-a-good-extension-if-you-first-deleted-it-from-the-world

Conversation

@spencer-lunarg

@spencer-lunarg spencer-lunarg commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

simpler version of #12908

@spencer-lunarg
spencer-lunarg requested a review from a team as a code owner August 21, 2026 14:25
@ci-tester-lunarg

ci-tester-lunarg commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 85876.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24197 running.

ziga-lunarg
ziga-lunarg reviewed Aug 21, 2026
View reviewed changes

@ziga-lunarg ziga-lunarg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take the positive test and change input_attachment_index to 1. That should give you a negative test with VUID-VkGraphicsPipelineCreateInfo-renderPass-09652 since now input attachment index is not less than color attachment count. In my PR this works, in yours it doesn't

@ci-tester-lunarg

ci-tester-lunarg commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24197 passed.

@spencer-lunarg

spencer-lunarg commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@ziga-lunarg good catch... the issue is the Fragment Shader library knows the InputAttachment index, but the Fragment Output knows the colorAttachmentCount

this means we need to validate this at the final linking, will fix

@spencer-lunarg
spencer-lunarg force-pushed the spencer-lunarg-i-think-gpl-could-be-a-good-extension-if-you-first-deleted-it-from-the-world branch from 8dfee10 to 71fe71f Compare August 22, 2026 00:16
@ci-tester-lunarg

ci-tester-lunarg commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 86736.

@spencer-lunarg

spencer-lunarg commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

@ziga-lunarg I ended up going towards the route you did, but shifted it a bit as I realize the concept of InputAttachment is really a "Shader Interface" and not a "SPIR-V" check so moved the logic from cc_spirv.cpp to cc_shader_interface.cpp

@ci-tester-lunarg

ci-tester-lunarg commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24211 running.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24211 failed.

@spencer-lunarg
spencer-lunarg force-pushed the spencer-lunarg-i-think-gpl-could-be-a-good-extension-if-you-first-deleted-it-from-the-world branch from 71fe71f to 72fa6bf Compare August 25, 2026 14:02
@ci-tester-lunarg

ci-tester-lunarg commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 90093.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24251 running.

ziga-lunarg
ziga-lunarg reviewed Aug 25, 2026
View reviewed changes
Comment thread layers/core_checks/cc_shader_interface.cpp Outdated
ziga-lunarg
ziga-lunarg reviewed Aug 25, 2026
View reviewed changes
Comment thread layers/core_checks/cc_shader_interface.cpp Outdated
@spencer-lunarg
spencer-lunarg force-pushed the spencer-lunarg-i-think-gpl-could-be-a-good-extension-if-you-first-deleted-it-from-the-world branch from 72fa6bf to 7358a5f Compare August 25, 2026 16:05
@ci-tester-lunarg

ci-tester-lunarg commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 90346.

@spencer-lunarg
spencer-lunarg force-pushed the spencer-lunarg-i-think-gpl-could-be-a-good-extension-if-you-first-deleted-it-from-the-world branch from 7358a5f to ea56ee7 Compare August 25, 2026 16:08
@ci-tester-lunarg

ci-tester-lunarg commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 90358.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24253 running.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24253 passed.

@spencer-lunarg
spencer-lunarg merged commit 9340c31 into KhronosGroup:main Aug 25, 2026
21 checks passed
@spencer-lunarg
spencer-lunarg deleted the spencer-lunarg-i-think-gpl-could-be-a-good-extension-if-you-first-deleted-it-from-the-world branch August 25, 2026 19:33
@spencer-lunarg

spencer-lunarg commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Just another day training all the LLM how to use GPL ☠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ziga-lunarg ziga-lunarg ziga-lunarg approved these changes

Assignees

@ziga-lunarg ziga-lunarg

Labels

GPL ☠️

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spencer-lunarg @ci-tester-lunarg @ziga-lunarg