Skip to content

layers: Add qcom filter cubic extension vuids - #12848

Merged
spencer-lunarg merged 1 commit into
KhronosGroup:mainfrom
ZZKQcom:qcom/filter_cubic_x
Aug 26, 2026
Merged

layers: Add qcom filter cubic extension vuids#12848
spencer-lunarg merged 1 commit into
KhronosGroup:mainfrom
ZZKQcom:qcom/filter_cubic_x

Conversation

@ZZKQcom

@ZZKQcom ZZKQcom commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Overview

Adds validation for VK_QCOM_filter_cubic, VK_QCOM_filter_cubic_clamp and VK_QCOM_filter_cubic_weights extensions:

  • VUID-VkFilterCubicImageViewImageFormatPropertiesEXT-pNext-02627
  • VUID-vkCmdDispatch-cubicRangeClamp-09212
  • VUID-vkCmdDispatch-reductionMode-09213
  • VUID-VkBlitImageInfo2-filter-09204
  • VUID-vkCmdDispatch-selectableCubicWeights-09214

Unit Tests

Test VUID & Description
FilterCubicImageViewImageFormatPropertiesMissingImageViewInfo 02627
FilterCubicImageViewImageFormatPropertiesIncompatibleImageViewType 02627
BlitImageButUseNonCatmullRomWeights 09204
FilterCubicRangeClampWithIncorrectReducionModeSampler 09212
AverageRangeClampReductionModeWithIncorrectFilterSampler 09213
FilterCubicWeightsWithNonCatmullRomSampler 09214
FilterCubicRangeClampWithReducionMode Positive
BlitImageWithFilterCubicWeights Positive
FilterCubicWeights Positive

@ZZKQcom
ZZKQcom requested a review from a team as a code owner August 11, 2026 06:57
@ci-tester-lunarg

ci-tester-lunarg commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build.

@ZZKQcom

ZZKQcom commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Related to #11339

spencer-lunarg
spencer-lunarg reviewed Aug 12, 2026
View reviewed changes
Comment thread layers/drawdispatch/descriptor_validator.cpp Outdated
spencer-lunarg
spencer-lunarg reviewed Aug 12, 2026
View reviewed changes
Comment thread layers/stateless/sl_image.cpp Outdated
spencer-lunarg
spencer-lunarg reviewed Aug 12, 2026
View reviewed changes
Comment thread layers/stateless/sl_instance_device.cpp
spencer-lunarg
spencer-lunarg reviewed Aug 12, 2026
View reviewed changes
Comment thread layers/utils/image_utils.cpp
spencer-lunarg
spencer-lunarg reviewed Aug 12, 2026
View reviewed changes
Comment thread tests/unit/sampler.cpp Outdated
@ZZKQcom
ZZKQcom force-pushed the qcom/filter_cubic_x branch from f086ed1 to b3caa5d Compare August 13, 2026 04:32
@ci-tester-lunarg

ci-tester-lunarg commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build.

@ZZKQcom
ZZKQcom requested a review from spencer-lunarg August 14, 2026 01:00
@ZZKQcom
ZZKQcom force-pushed the qcom/filter_cubic_x branch from b3caa5d to bc24f5a Compare August 14, 2026 01:19
@ci-tester-lunarg

ci-tester-lunarg commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build.

@ZZKQcom
ZZKQcom force-pushed the qcom/filter_cubic_x branch from bc24f5a to 157610d Compare August 14, 2026 11:19
@ci-tester-lunarg

ci-tester-lunarg commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build.

spencer-lunarg
spencer-lunarg reviewed Aug 19, 2026
View reviewed changes
Comment thread layers/drawdispatch/descriptor_validator.cpp Outdated
spencer-lunarg
spencer-lunarg reviewed Aug 19, 2026
View reviewed changes
Comment thread layers/drawdispatch/descriptor_validator.cpp Outdated
spencer-lunarg
spencer-lunarg reviewed Aug 19, 2026
View reviewed changes
Comment thread layers/utils/image_utils.h Outdated
spencer-lunarg
spencer-lunarg reviewed Aug 19, 2026
View reviewed changes
Comment thread layers/utils/image_utils.cpp Outdated
@ZZKQcom
ZZKQcom force-pushed the qcom/filter_cubic_x branch from 157610d to 2c7ee4d Compare August 21, 2026 03:23
@ci-tester-lunarg

ci-tester-lunarg commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build.

@ZZKQcom
ZZKQcom requested a review from spencer-lunarg August 21, 2026 06:17
@ZZKQcom
ZZKQcom force-pushed the qcom/filter_cubic_x branch from 2c7ee4d to c5deed1 Compare August 24, 2026 01:45
@ci-tester-lunarg

ci-tester-lunarg commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build.

spencer-lunarg
spencer-lunarg reviewed Aug 25, 2026
View reviewed changes
Comment thread layers/drawdispatch/descriptor_validator.cpp Outdated
spencer-lunarg
spencer-lunarg approved these changes Aug 25, 2026
View reviewed changes

@spencer-lunarg spencer-lunarg left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with final nit fix (also needs to be rebased)

@ci-tester-lunarg

ci-tester-lunarg commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 90056.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24249 running.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24249 passed.

@ZZKQcom
ZZKQcom force-pushed the qcom/filter_cubic_x branch from c5deed1 to 818d3a6 Compare August 26, 2026 01:46
@ci-tester-lunarg

ci-tester-lunarg commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Author ZZKQcom not on autobuild list. Waiting for curator authorization before starting CI build.

@spencer-lunarg
spencer-lunarg merged commit eaf4bf5 into KhronosGroup:main Aug 26, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnetsch mnetsch mnetsch left review comments
@spencer-lunarg spencer-lunarg spencer-lunarg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZZKQcom @ci-tester-lunarg @mnetsch @spencer-lunarg