Attempt to address the build size issue in Windows - #1563
Open
gpx1000 wants to merge 3 commits into
Open
Conversation
…bj files once the .lib is created. Also use static libs, also change the debugger flags as necessary to improve the build size while maintaining debugability.
20 tasks
| function(vkb__trim_static_lib_objects TARGET_NAME) | ||
| if(MSVC AND (DEFINED CMAKE_C_COMPILER_LAUNCHER) AND (CMAKE_GENERATOR MATCHES "Ninja|Makefiles")) | ||
| add_custom_command(TARGET ${TARGET_NAME} POST_BUILD | ||
| COMMAND ${CMAKE_COMMAND} -E rm -rf "${CMAKE_CURRENT_BINARY_DIR}/CMakeFiles/${TARGET_NAME}.dir" |
Collaborator
There was a problem hiding this comment.
Will "rm -rf" work on windows?
Collaborator
Author
There was a problem hiding this comment.
no, but cmake -E rm rf tells cmake to use it's portable remove function. Thus it should work. The problem for why it didn't work was the if check above it.
tomek-brcm
approved these changes
Aug 24, 2026
tomek-brcm
left a comment
There was a problem hiding this comment.
Builds fine on Linux, no regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by removing the .obj files once the .lib is created. Also use static libs, also change the debugger flags as necessary to improve the build size while maintaining debugability.
Description
Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context.
Please read the contribution guidelines
Fixes #
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: