Improve system init detection and runit compatibility in setup.sh#95
Open
NonameBlank007 wants to merge 3 commits into
Open
Improve system init detection and runit compatibility in setup.sh#95NonameBlank007 wants to merge 3 commits into
NonameBlank007 wants to merge 3 commits into
Conversation
1. The previous commit didn't account for correct "sv" path. 2. The previous setup gave priority to artix runit setup, but sv path was incorrect - Its "/etc/runit/sv", but accidentaly gave "/etc/sv" which dosen't exist. - So, improve it by adding various other check and make it a branch "if-elif" check. - Called '_runit_sv'. 3. Improve on/default to first check for current running system dir's insted. - Prioritise current running insted of Not/Enabled symlinked "/etc/runit/runsvdir/default". - Above should only gave priority if it is not enabled/running. - So, not recommended. link of ref: [1]: https://docs.voidlinux.org/config/services/index.html | Enabling Services [2]: https://wiki.gentoo.org/wiki/Runit#Runit_and_service_management | 3.4.2 [3]: https://wiki.artixlinux.org/Main/Runit | Basic usage Signed-off-by: Noname Blank <nonameblank007@gmail.com>
It requires additional sddm-runit to add to service file directory (e.g., Artix-runit) Signed-off-by: Noname Blank <nonameblank007@gmail.com>
Keyitdev
reviewed
Jul 13, 2026
Keyitdev
requested changes
Jul 13, 2026
- Download additional pkg only if os-release ID=artix
Owner
|
I’ll merge it soon (I’ve got other pull requests and want to avoid conflicts), thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Keyitdev, Pick this up insted of #94 (i'm closing it). Also i have tested others on VM as well and they are fine as they are, only runit needed work.