Skip to content

Use lake exe cache get to skip rebuilding Mathlib #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabrielebattimelli merged 1 commit into from
Apr 23, 2026
+2 −2
Merged

Use lake exe cache get to skip rebuilding Mathlib #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/weekly-index.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ jobs:

- name: Build PhysLib
if: steps.check.outputs.has_changes == 'true'
run: cd physlib && lake build
timeout-minutes: 90
run: cd physlib && lake exe cache get && lake build
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build step is now chained with &&, so any transient failure in lake exe cache get (network, cache server, missing artifact) will prevent lake build from running. If the intent is “use cache when available, otherwise fall back to building”, make cache get non-fatal (e.g., separate step or handle its exit code) so the workflow still proceeds to lake build.

Suggested change
run: cd physlib && lake exe cache get && lake build
run: |
cd physlib
lake exe cache get || echo "lake exe cache get failed; continuing with lake build"
lake build

Copilot uses AI. Check for mistakes.
timeout-minutes: 30
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeout-minutes was reduced from 90 to 30. If lake exe cache get is unavailable or the cache misses, the subsequent lake build may exceed 30 minutes and get killed even though it would succeed. Consider keeping a longer timeout (or making it conditional on cache-get success) to avoid flaky weekly runs.

Suggested change
timeout-minutes: 30
timeout-minutes: 90

Copilot uses AI. Check for mistakes.

# jixia must be cloned before its cache step
- name: Clone jixia
Expand Down
Loading