fix(vm): fail fast when cidata profiles lack cloud-localds#78
Merged
Conversation
The silent vvfat config-drive fallback cost two full publish-lane runs to diagnose: RHEL-family/Amazon/Oracle/SUSE guests never boot from it on some hosts (0-byte serial), so the failure surfaced 15 minutes later per target as an opaque "wait for SSH: not ready" infra error. seedDeliveryForProfile now returns an error when a profile needs a cidata seed ISO and cloud-localds is not installed, carrying the fix in the message: install cloud-image-utils, or explicitly opt back into the legacy fallback with BPFCOMPAT_ALLOW_VVFAT_SEED=1 (new env var, cataloged in internal/envref + docs/env-reference.md). When the opt-in is used, the run note warns what to do if the guest never reaches SSH. Tests: fail-fast error carries all three actionable hints; opt-in restores vvfat; ubuntu/debian NoCloud-net unaffected; CoreOS Ignition path unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #77. The silent vvfat config-drive fallback cost two full publish-lane runs to diagnose: RHEL-family/Amazon/Oracle/SUSE guests never boot from it on some hosts (0-byte serial), so the failure surfaced 15 minutes later per target as an opaque
wait for SSH: not readyinfra error.Change
seedDeliveryForProfilenow errors immediately when a profile needs a cidata seed ISO andcloud-localdsis missing, with the fix in the message:BPFCOMPAT_ALLOW_VVFAT_SEED(default off) keeps the legacy fallback reachable for hosts where it does work — cataloged ininternal/envref+ regenerateddocs/env-reference.md.Tests
cloud-localds,cloud-image-utils,BPFCOMPAT_ALLOW_VVFAT_SEED), verified with an emptyPATH;go test ./...green.🤖 Generated with Claude Code