Prefix MergeButler token environment variables#21
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MergeButler currently reads unprefixed token environment variables, which makes the token configuration surface inconsistent with the requested
MERGEBUTLER__...names. This change switches the runtime token lookup and all user-facing guidance to the prefixed variables only.The implementation centralizes the token environment-variable names in
PlatformServiceFactory, reuses that source of truth in the CLI and MCP fallback messages, and updates the README anddoc-writerskill docs to match. The tests were tightened to verify both that the prefixed variables are used and that the legacyGITHUB_TOKEN/AZURE_DEVOPS_TOKENnames are ignored.Validation
dotnet build .\MergeButler.slnx --no-restoredotnet run --project .\MergeButler -- evaluate --helpdotnet run --project .\MergeButler -- evaluate --pr https://github.com/owner/repo/pull/1 --platform GitHub --dry-runwith onlyGITHUB_TOKENset still reportsMERGEBUTLER__GITHUB_TOKENas missingNotes
dotnet test --solution .\MergeButler.slnx --no-buildstill fails before running tests because of the existingMicrosoft.Testing.PlatformTypeLoadException.