fix(cache): pass graced entry to factory in SWR path#116
Open
niksy wants to merge 1 commit intoJulien-R44:mainfrom
Open
fix(cache): pass graced entry to factory in SWR path#116niksy wants to merge 1 commit intoJulien-R44:mainfrom
niksy wants to merge 1 commit intoJulien-R44:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SWR mode,
getOrSetcould invoke the factory withgracedEntryset toundefinedeven when a stale value existed. This happened because the SWR background factory run did not receivegracedValue.gracedValueis now forwarded in that path sogracedEntry.valueis consistently available.I went ahead and adjusted tests so previous codebase fails, but new one passes. Previous assertion actually throws with
AssertionError: expected undefined to deeply equal 'bar'but it’s not thrown since grace period for that test is set to 2 minutes and the graced value is returned, but that graced value is not available in factory context, only as return value ofgetOrSetcall.