Refactor testsetup handling#138
Open
nickrobinson251 wants to merge 3 commits into
Open
Conversation
nickrobinson251
force-pushed
the
npr-refactor-testsetup-handling
branch
from
September 12, 2024 22:15
d782502 to
5f91402
Compare
nickrobinson251
force-pushed
the
npr-refactor-testsetup-handling
branch
from
August 4, 2025 13:30
5f91402 to
22591f9
Compare
nickrobinson251
marked this pull request as ready for review
August 4, 2025 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testsetupfield with Dict mapping name to code, so we can rely solely ontestsetupfield and lookup code directly.@testsetupautomatically available to@testitemdefined in the same file #60 easier (we can just add them to thetestsetupfield, and leave thesetupfield untouched as the field that stores the explicltly statedsetups=[...])runtestsetupsto ensure all the setup modules are created, perhaps with its own timer, before runningruntestitemagainst the timer)