Drop deviance and reformat lrtest table#346
Open
andreasnoack wants to merge 1 commit into
Open
Conversation
Removes the `Deviance` field from `LRTestResult` and the corresponding column from the printed table. Renames the remaining columns and uses χ² instead of `Chisq`, with the order: `LogLik`, `p`, `χ²`, `df`, `p(>χ²)`. Headers are centered to match the GLM `ftest` style.
Member
Author
|
I don't think it is common to talk about the residual or model degrees of freedom in a likelihood setting. You usually talk about the number of parameters in the model, here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deviancefield fromLRTestResultand the matching column from the printed table.LogLik,p(number of parameters),χ²,df(Δ degrees of freedom),p(>χ²).an/ftestbranch of GLM.Before
After
Test plan
Pkg.test()for thelrtesttestset passes (73/73)lrtestdocstring matches the new format on CI