use normal entrypoints into base's display pipeline#736
Open
rokke-git wants to merge 3 commits into
Open
Conversation
Base and SparseArrays had some funky action-at-a-distance stuff going on, this fully disentangles them. this also makes SparseArrays a little smarter about when to swap to braille, and actually uses the whole screen instead of just the left half. it's also theoretically doing less work now, but it's just a printing function so whatever. width of displayed zeros also doesn't depend on the type anymore, so that error goes away; added in a warning to replace it.
Author
|
lol, guess the doctests are a good way of displaying what's changed... |
rokke-git
force-pushed
the
detangle-output
branch
4 times, most recently
from
0516cde to
5e7647d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
+ Coverage 84.40% 84.49% +0.08%
==========================================
Files 13 13
Lines 9374 9409 +35
==========================================
+ Hits 7912 7950 +38
+ Misses 1462 1459 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rokke-git
force-pushed
the
detangle-output
branch
3 times, most recently
from
64088f3 to
187b579
Compare
rokke-git
force-pushed
the
detangle-output
branch
from
187b579 to
2a637f6
Compare
rokke-git
force-pushed
the
detangle-output
branch
from
703aaf0 to
efbbf85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base and SparseArrays had some funky action-at-a-distance stuff going on, this fully disentangles the printing functions. this is what I really came over here for, the type thing was just me hoping to simplify things a bit. didn't end up effecting much, but does add the
circular_referenceline.it also makes SparseArrays a little smarter about when to swap to braille output, and actually uses the whole screen instead of just the left half. it's also theoretically doing less work now, but it's just a printing function so whatever. the width of displayed zeros also doesn't depend on the type anymore, and is always centered.
since this removes the error that used to come up during printing, I added in a new warning to replace it.
fixes: #21, #22, #233, #618