Skip to content

Update breakage: use organization-wide workflow#35

Merged
tmigot merged 2 commits intoJuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage
May 8, 2026
Merged

Update breakage: use organization-wide workflow#35
tmigot merged 2 commits intoJuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage

Conversation

@MaxenceGollier
Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings April 28, 2026 15:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s breakage CI to rely on JuliaSmoothOptimizers’ organization-wide reusable workflows (per JuliaSmoothOptimizers/.github#18), and removes the now-redundant local breakage implementation.

Changes:

  • Replace the in-repo Breakage workflow logic with a call to the org reusable Breakage.yml.
  • Add a workflow_run-triggered workflow to post PR comments via the org reusable CommentBreakage.yml.
  • Remove the local .breakage helper script and project dependencies that are no longer used.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
.github/workflows/CommentBreakage.yml Adds a workflow_run-based wrapper to call the org-wide PR-commenting workflow.
.github/workflows/Breakage.yml Simplifies Breakage to a reusable-workflow invocation.
.breakage/get_jso_users.jl Removes local dependency-discovery script (superseded by org workflow).
.breakage/Project.toml Removes local breakage workflow dependencies (superseded by org workflow).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +5
name: Comment Breakage

on:
workflow_run:
workflows: ["Breakage"]
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_run workflows often need explicit permissions because the called reusable workflow cannot elevate the GITHUB_TOKEN. Since this job is intended to comment on PRs (as the workflow name implies), set top-level permissions (e.g., pull-requests: write plus any required actions/contents read scopes for downloading artifacts) so commenting doesn’t fail under read-only default token settings.

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/CommentBreakage.yml Outdated
Comment thread .github/workflows/CommentBreakage.yml
Comment thread .github/workflows/Breakage.yml Outdated
Comment thread .github/workflows/Breakage.yml
Copy link
Copy Markdown
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MaxenceGollier !

@tmigot tmigot merged commit d771a3e into JuliaSmoothOptimizers:main May 8, 2026
14 of 16 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (4572631) to head (09e5e9c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   89.88%   89.67%   -0.21%     
==========================================
  Files           1        1              
  Lines         346      339       -7     
==========================================
- Hits          311      304       -7     
  Misses         35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants