Update breakage: use organization-wide workflow#35
Update breakage: use organization-wide workflow#35tmigot merged 2 commits intoJuliaSmoothOptimizers:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s breakage CI to rely on JuliaSmoothOptimizers’ organization-wide reusable workflows (per JuliaSmoothOptimizers/.github#18), and removes the now-redundant local breakage implementation.
Changes:
- Replace the in-repo Breakage workflow logic with a call to the org reusable
Breakage.yml. - Add a
workflow_run-triggered workflow to post PR comments via the org reusableCommentBreakage.yml. - Remove the local
.breakagehelper script and project dependencies that are no longer used.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .github/workflows/CommentBreakage.yml | Adds a workflow_run-based wrapper to call the org-wide PR-commenting workflow. |
| .github/workflows/Breakage.yml | Simplifies Breakage to a reusable-workflow invocation. |
| .breakage/get_jso_users.jl | Removes local dependency-discovery script (superseded by org workflow). |
| .breakage/Project.toml | Removes local breakage workflow dependencies (superseded by org workflow). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Comment Breakage | ||
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: ["Breakage"] |
There was a problem hiding this comment.
workflow_run workflows often need explicit permissions because the called reusable workflow cannot elevate the GITHUB_TOKEN. Since this job is intended to comment on PRs (as the workflow name implies), set top-level permissions (e.g., pull-requests: write plus any required actions/contents read scopes for downloading artifacts) so commenting doesn’t fail under read-only default token settings.
tmigot
left a comment
There was a problem hiding this comment.
LGTM, thanks @MaxenceGollier !
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
- Coverage 89.88% 89.67% -0.21%
==========================================
Files 1 1
Lines 346 339 -7
==========================================
- Hits 311 304 -7
Misses 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Following JuliaSmoothOptimizers/.github#18.