Skip to content

make A[begin:stride:end] work #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjarthur wants to merge 4 commits into
base: main
Choose a base branch
from
Open

make A[begin:stride:end] work #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d651096
make A[begin:stride:end] work
bjarthur Apr 16, 2026
a4bcbcb
fixup d6510969e177a6
bjarthur Apr 16, 2026
ebaa378
test begin and end
bjarthur Apr 16, 2026
0ed3eb4
Merge branch 'main' into bja/index
mkitti Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/TensorStoreWrapper.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ function Base.axes(w::TensorStoreWrapper)
max_indices = pyconvert(Vector{Int}, domain.exclusive_max)
return Tuple((min_indices[i]+1):max_indices[i] for i in 1:rank)
end
Base.axes(w::TensorStoreWrapper, d::Integer) = axes(w)[d]
Base.firstindex(w::TensorStoreWrapper, d::Integer) = first(axes(w, d))
Base.lastindex(w::TensorStoreWrapper, d::Integer) = last(axes(w, d))

function Base.show(io::IO, w::TensorStoreWrapper)
print(io, "TensorStore(", eltype(w), ", rank=", ndims(w), ", shape=", size(w), ")")
Expand Down Expand Up @@ -235,6 +238,9 @@ function Base.axes(w::IndexDomainWrapper)
max_indices = pyconvert(Vector{Int}, parent(w).exclusive_max)
return Tuple((min_indices[i]+1):max_indices[i] for i in 1:rank)
end
Base.axes(w::IndexDomainWrapper, d::Integer) = axes(w)[d]
Base.firstindex(w::IndexDomainWrapper, d::Integer) = first(axes(w, d))
Base.lastindex(w::IndexDomainWrapper, d::Integer) = last(axes(w, d))

"""
labels(w::IndexDomainWrapper) -> Vector{String}
Expand Down
8 changes: 8 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ using PythonCall
@test ndims(w) == 2
@test size(w) == (10, 20)
@test axes(w) == (1:10, 1:20)
@test firstindex(w, 1) == 1
@test lastindex(w, 1) == 10
@test lastindex(w, 2) == 20
@test size(w[begin:2:end, begin:2:end]) == (5,10)
end

@testset "Write & Read Operations" begin
Expand All @@ -45,6 +49,10 @@ using PythonCall
sub_w = w[x=1:5, y=11:15]
@test size(sub_w) == (5, 5)
@test axes(sub_w) == (1:5, 11:15)
@test firstindex(sub_w, 1) == 1
@test lastindex(sub_w, 1) == 5
@test lastindex(sub_w, 2) == 15
@test size(sub_w[begin:2:end, begin:2:end]) == (3,3)

# translate_by
tw = PyTensorStore.translate_by(w, 10, 20)
Expand Down
Loading