add size(A,d) methods#3
Conversation
|
How about |
There was a problem hiding this comment.
Pull request overview
Adds size(A, d) support for TensorStoreWrapper and IndexDomainWrapper to better match Julia’s array interface.
Changes:
- Implement
Base.size(::TensorStoreWrapper, ::Integer)with out-of-range dimensions returning1. - Implement
Base.size(::IndexDomainWrapper, ::Integer)similarly. - Extend tests to cover
size(x, d)for both wrappers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/TensorStoreWrapper.jl |
Adds Base.size(w, d) overloads for the wrapper types. |
test/runtests.jl |
Adds assertions validating size(x, d) behavior (including d > ndims). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
the tests pass for me on MacOS. i can reproduce though on ubuntu. all that is required is to what i don't understand though, is that in a |
|
I merged #5 into this branch and main, which should resolve the issue. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot any further comments on this pull request? |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
with help from claude.
@mkitti