[SPIRV] add workaround for khronos translator#879
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
+ Coverage 81.57% 81.59% +0.01%
==========================================
Files 25 25
Lines 4847 4851 +4
==========================================
+ Hits 3954 3958 +4
Misses 893 893 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
maleadt
approved these changes
Jul 15, 2026
maleadt
left a comment
maleadt
left a comment
Member
There was a problem hiding this comment.
LGTM. Why are you still using the Khronos translator?
Co-authored-by: Tim Besard <tim.besard@gmail.com>
Member
Author
|
It was mostly motivated by us still running into issues with the LLVM backend like JuliaGPU/OpenCL.jl#422, so I was just curious what things looked like on the Khronos translator side nowadays. Not sure we ever want to switch back, but it's nice to have another option if we ever do run into any major blockers with the LLVM backend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
works around KhronosGroup/SPIRV-LLVM-Translator#3389