Stop at breakpoints on a function's initial statements#405
Merged
Conversation
Two places used to skip such breakpoints: - `@make_frame` advanced to the first call with `maybe_next_call!`, executing any breakpointed non-call statement before it. - `@run` unconditionally executed `c`, which steps over a breakpoint on the statement the frame is already stopped at, so a breakpoint on the first statement never fired. Reimplements #148 by pfitzseb on current master. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two places used to skip breakpoints set on a function's first statement(s):
@make_frameadvanced to the first call withmaybe_next_call!, executing any breakpointed non-call statement on the way.@rununconditionally executedc, which steps over a breakpoint on the statement the frame is already stopped at, so a breakpoint on the first statement never fired and@runran to completion.Now
@make_frameadvances with a predicate that also stops at breakpointed statements, and@runskips the initialcwhen the entry statement has a breakpoint, showing the prompt there instead.Reimplements #148 by @pfitzseb on current master. Adds a unit test and a UI regression test.
Fixes #134
Closes #148
🤖 Generated with Claude Code