Fix EssentialsX home conversion for active and new players - #399
Merged
John-Paul-R merged 1 commit intoAug 29, 2026
Merged
Conversation
John-Paul-R
approved these changes
Aug 29, 2026
Owner
|
Nice fix, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes EssentialsX home conversion in two cases:
Written with GPT 5.6 so use with caution.
When a player is currently online, imported homes are merged into the active
PlayerDatainstance. This prevents the converted homes from being overwritten when the player's active data is later saved.When no existing Essential Commands player data exists, the newly created
PlayerDatais populated with the imported homes.This addresses the conversion behavior described in #357.
Testing
Tested on Fabric 26.2 / Essential Commands 0.41.0.
The fix was previously tested in the patched JAR, including persistence of converted homes and conversion for players without existing Essential Commands player data.
The project builds successfully with Gradle.
Fixes #357