Improve dex2oat wrapper mounting and add XmlUtils stub#761
Open
HSSkyBoy wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the dex2oat wrapper mount logic and adds the missing
XmlUtils.readMapXml(InputStream)hidden API stub needed byXSharedPreferences.Changes
com.android.internal.util.XmlUtils.readMapXml(InputStream)to hiddenapi stubs soXSharedPreferencescan resolve the internal API surface cleanly.Motivation
XSharedPreferencesdepends on Android's internalXmlUtils.readMapXmlmethod for parsing preference XML files. Providing the stub keeps the hidden API surface available at build time.The dex2oat wrapper mount path also had duplicated logic for regular/debug and 32/64-bit binaries. The refactor keeps the existing behavior while making the mount targets easier to follow and maintain.