fix: mark menu notices as disabled options#6101
Draft
wanxiankai wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: aee0894 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
role="option"andaria-disabled="true"to loading and no-options notice components throughinnerProps.role="listbox"container.react-select.Why
When the menu is loading or has no matching options, react-select currently renders a plain notice
<div>as the only child of arole="listbox". A listbox must own at least onerole="option"orrole="group", so axe reports anaria-required-childrenviolation.Treating these non-selectable notices as disabled options preserves the existing visual and runtime behavior while giving the listbox a valid ARIA child. Passing the attributes through
innerPropsalso allows custom notice components that forward those props to retain the same semantics.Closes #6093.
Validation
yarn test:jest --runInBand— 5 suites, 257 tests passedyarn type-checkyarn buildyarn lintyarn prettier --check .changeset/calm-listboxes-notice.md packages/react-select/src/Select.tsx packages/react-select/src/__tests__/Select.test.tsxyarn changeset status— patch bump forreact-selectgit diff --check