docs(contributing): SKILL.md's port-8080 strictPort claim is false outside a Lovable sandbox#7630
Merged
Merged
Conversation
SKILL.md claimed "Vite forces port 8080 regardless of what you
request." False outside a Lovable sandbox: strictPort: true in
@lovable.dev/vite-tanstack-config is gated on isSandbox -- on a
normal contributor machine, CI runner, or AI-agent worktree, port
8080 is a plain default with no strictPort, so an occupied 8080
silently shifts to the next free port with only one easy-to-miss
console line and no error.
Reproduced directly: ran the dev server with 8080 already occupied,
got "Port 8080 is in use, trying another one..." then a server on
8081, no sandbox warning. Exactly the failure mode the doc itself
warns about ("preview_screenshot-style tooling just hangs waiting for
the server"), except the doc framed the port as guaranteed instead of
best-effort -- misleading guidance for the exact audience (AI agents
following it literally) most likely to hardcode the port without
reading the startup log.
Corrects the doc to describe the actual behavior and tells the reader
to check the server's real Local: URL instead of assuming 8080.
Closes #7628
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7628
Summary
SKILL.mdclaimed Vite "forces port 8080 regardless of what you request" — false outside a Lovablesandbox (
strictPort: trueis gated onisSandbox). Reproduced directly: an occupied 8080 silentlyshifts to 8081 with no error. Corrects the doc to describe the actual best-effort behavior and tells
the reader to check the server's real
Local:URL instead of assuming the port.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
.claude/, not a code change — no test coverage applies. Verified viadirect reproduction (ran the dev server with port 8080 pre-occupied and observed the actual, undocumented
fallback behavior) rather than a new test.
Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Not applicable — documentation-only change.
Notes
(the
vite previewfix earlier in this line of work).