Skip to content

test(unit): give the multi-scenario defaultBaseRef test a longer budget#7609

Merged
loopover-orb[bot] merged 1 commit into
mainfrom
test/local-branch-timeout-budget
Jul 21, 2026
Merged

test(unit): give the multi-scenario defaultBaseRef test a longer budget#7609
loopover-orb[bot] merged 1 commit into
mainfrom
test/local-branch-timeout-budget

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • test/unit/local-branch.test.ts's "defaultBaseRef prefers a fetched origin/HEAD, then origin/main, then origin/master when present" test does three full real-git round trips in sequence (each: mkdtemp, fixture init, an execFileSync git call, one or two update-ref/symbolic-ref calls, a collectLocalBranchMetadata call that itself shells out to git, then cleanup) to cover the origin/HEAD, origin/main, and origin/master precedence cases in one test.
  • In isolation it reliably finishes in ~5-8s; under the CPU/I-O contention of the full ~19,500-test unsharded suite running concurrently, it can cross the default 15s vitest timeout even though nothing is actually hung — reproduced with a real timeout error (not an assertion failure), while real CI stayed green on the same commit.
  • Fix: bump this specific test's timeout to 30s, the same per-test override pattern already used elsewhere in this suite for other legitimately slower tests (e.g. test/unit/mcp-cli-maintain.test.ts's 45_000). No logic or assertion changes.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • This is a test-only change (test/unit/local-branch.test.ts), no src/** touched, so it carries no Codecov patch obligation. npm run ui:build/ui:test did not complete locally: this machine runs Node v26.5.0 (repo pins Node 22 via .nvmrc), and every apps/loopover-ui/apps/loopover-miner-ui test touching window.localStorage fails locally with a vitest-jsdom/Node compatibility error unrelated to this diff (already tracked separately). The full backend gate ran clean through ui:typecheck other than one unrelated real-git-subprocess test (test/unit/miner-attempt-worktree.test.ts) that also timed out only under the same full-suite contention and passed cleanly (4.48s, all 8 tests) in isolation — the identical class of issue this PR fixes, in a different file, not touched here to keep this PR narrow.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — test-only change (test/unit/local-branch.test.ts), no visible UI/frontend/docs surface.

Notes

This test does three full real-git round trips in sequence (mkdtemp,
fixture init, several git subprocess calls, and cleanup, repeated for
the origin/HEAD, origin/main, and origin/master precedence cases),
which reliably finishes in seconds in isolation but can cross the
default 15s timeout under the CPU/I-O contention of the full unsharded
suite. Bump it to 30s, the same override pattern already used
elsewhere in this suite for other real-subprocess-heavy tests.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jul 21, 2026
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.49%. Comparing base (a2927e9) to head (54cdb05).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7609      +/-   ##
==========================================
- Coverage   88.50%   88.49%   -0.02%     
==========================================
  Files         724      724              
  Lines       75959    75959              
  Branches    22609    22609              
==========================================
- Hits        67230    67219      -11     
- Misses       7681     7688       +7     
- Partials     1048     1052       +4     
Flag Coverage Δ
shard-1 33.72% <ø> (ø)
shard-2 41.09% <ø> (-0.07%) ⬇️
shard-3 33.37% <ø> (ø)
shard-4 39.21% <ø> (-0.02%) ⬇️
shard-5 28.23% <ø> (ø)
shard-6 28.75% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 21, 2026
@loopover-orb

loopover-orb Bot commented Jul 21, 2026

Copy link
Copy Markdown

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-21 01:15:43 UTC

1 file · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
One-line change adding a 30s per-test timeout override to a flaky-under-load git-fixture test in test/unit/local-branch.test.ts, matching an existing pattern already used elsewhere in the suite (e.g. mcp-cli-maintain.test.ts's 45_000). No logic or assertion changes, CI is green, and the fix is proportionate to the stated problem.

Nits — 2 non-blocking
  • The PR description doesn't link an open issue as the repo's contributing checklist requires for every contributor PR, and the checkbox claiming it does isn't substantiated in the diff/description shown.
  • If flakiness under full-suite contention recurs across other real-git round-trip tests, consider a shared default timeout constant instead of per-test overrides to avoid this pattern spreading ad hoc across the file.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #7600
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 23 registered-repo PR(s), 16 merged, 368 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 23 PR(s), 368 issue(s).
Improvement ℹ️ Insufficient signal risk: clean · value: insufficient-signal · LLM: minor
Linked issue satisfaction

Addressed
The diff applies a 30_000ms timeout override to exactly the flagged test, matching the fix requested in the issue and the existing pattern cited (mcp-cli-maintain.test.ts's 45_000), with no logic or assertion changes.

Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
  • Official Gittensor activity: 23 PR(s), 368 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 6a2ae5b into main Jul 21, 2026
17 checks passed
@loopover-orb
loopover-orb Bot deleted the test/local-branch-timeout-budget branch July 21, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(unit): local-branch.test.ts's defaultBaseRef test times out under full-suite contention

1 participant