fix(test): pin miner-ui jsdom localStorage over Node 26's broken global

[bitfathers94]

fix(test): pin miner-ui jsdom localStorage over Node 26's broken global

Node 26 predefines an experimental globalThis.localStorage accessor
(nodejs/node#60303) that returns undefined without --localstorage-file.
It exists on globalThis before jsdom's environment is installed, so
Vitest's populateGlobal skips copying jsdom's working Storage over it and
every bare localStorage call (theme-toggle.test.tsx, mirroring
theme-toggle.tsx) throws under Node 26 while passing on Node 22/24.

Point globalThis.localStorage at jsdom's real Storage from the raw JSDOM
window unconditionally: a no-op where the global already is that object,
the fix on Node 26+. A ??= guard would keep the broken accessor since it
already counts as present.

Closes #7592

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-21 00:35:20 UTC}

1 file · 1 AI reviewer · no blockers · readiness 100/100 · CI green · unknown

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This adds an unconditional `Object.defineProperty` in vitest.setup.ts that re-points `globalThis.localStorage` at the real jsdom Storage object pulled off `globalThis.jsdom.window.localStorage`, working around Node 26's own experimental `localStorage` accessor that Vitest's `populateGlobal` won't overwrite because the property already exists. The reasoning in the comment is sound and matches the linked Node issue (nodejs/node#60303), and the guard is correctly a hard reassignment rather than `??=` since a `??=` would keep the broken Node accessor. The change is narrowly scoped to the exact failure described in #7592 and closes it directly.

Nits — 5 non-blocking

• The fix depends on `globalThis.jsdom.window.localStorage` existing, which is an internal implementation detail of vitest-environment-jsdom rather than a documented public API — worth a one-line comment noting this is unstable across vitest-environment-jsdom versions and can silently become a no-op again if that internal shape changes.
• No new/updated test was added to pin this behavior going forward; since CI here almost certainly runs on Node <26, this hunk is exercised as a no-op in CI and its actual fix path (Node 26) isn't verified by this PR's own test run.
• Consider adding a small assertion in vitest.setup.ts (e.g. throw if `jsdomLocalStorage` is falsy) so a future vitest-environment-jsdom upgrade that changes the internal `globalThis.jsdom` shape fails loudly instead of silently reverting to the broken Node 26 accessor.
• If feasible, add a Node-version-gated CI job (or document in CI config) that actually runs on Node 26 to validate this fix exercises its real branch, not just the Node 22/24 no-op branch.
• Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#7592
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 63 registered-repo PR(s), 40 merged, 0 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	bitfathers94; Gittensor profile; 63 PR(s), 0 issue(s).
Improvement	ℹ️ None detected	risk: low · value: none

Review context

• Author: bitfathers94
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 63 PR(s), 0 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview

Route	Viewport	Before (production)	After (this PR's preview)	Diff
/	desktop	before /	after /	—
/	mobile	before / (mobile)	after / (mobile)	—

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview

Route	Before (production)	After (this PR's preview)
/	before / (scroll)	—

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.