fix(release): merge engine's release with its dependents (mcp, miner)#7114
Merged
Conversation
The actual root cause of the mcp/miner v3.1.x release churn: engine's release and its dependents' (mcp, miner both carry a real runtime `dependencies` entry on it) release each landed as SEPARATE PRs/commits. release-please's node-workspace plugin still bumped a dependent's `@loopover/engine` version range the moment engine's version changed, but on the dependent's OWN branch -- so the dependent's package.json ended up requiring an engine version that existed nowhere (not locally, since engine's bump lived on a different unmerged branch; not on npm, since it hadn't published yet). `npm ci` failed with ETARGET until a human manually walked engine through to publish first, then updated the dependent's branch -- confirmed live across #7086/#7087/#7107/#7108. merge: true is the plugin's own purpose-built mechanism for exactly this: it combines a package with the dependents its OWN dependency-bump logic pulled in as candidates into ONE PR/commit, so engine's new version and its dependents' bumped ranges land together atomically. npm workspaces then resolves the dependency from the LOCAL checkout, which always satisfies the range regardless of npm registry publish timing or ordering -- eliminating the failure mode structurally rather than papering over it with an after-the-fact branch-update step. ui-kit has no dependency edge to any other package here, so it's never pulled into the merge and keeps its fully independent release cadence.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This was referenced Jul 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7114 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 692 692
Lines 68808 68809 +1
Branches 18781 18781
=======================================
+ Hits 64511 64512 +1
Misses 3302 3302
Partials 995 995
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Jul 17, 2026
galuis116
pushed a commit
to galuis116/gittensory
that referenced
this pull request
Jul 18, 2026
JSONbored#7114's node-workspace merge:true was insufficient -- verified against release-please's own manifest.ts and docs/manifest-releaser.md that separate-pull-requests: true is enforced as the final PR-splitting decision regardless of what a plugin like node-workspace attempts internally, so mcp/miner's Release PRs kept landing separately from engine's even with that flag set (confirmed live: JSONbored#7119/JSONbored#7120/JSONbored#7121 still required an unpublished @loopover/engine version each). linked-versions is release-please's actual mechanism for overriding per-component isolation for a named subset: {engine, mcp, miner} now release as one PR/commit whenever any of them needs a release, since mcp and miner both carry a real runtime dependency on engine. ui-kit has no dependency edge to any of them and is not in the group, so it keeps its fully independent cadence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The actual root cause of the mcp/miner v3.1.x release churn this session (#7086, #7087, #7107, #7108): engine's release and its dependents' (
packages/loopover-mcpandpackages/loopover-minerboth carry a real runtimedependenciesentry on@loopover/engine) release each landed as separate PRs/commits.release-please's
node-workspaceplugin still bumps a dependent's@loopover/engineversion range the moment engine's own version changes -- that part is correct and desired. But withmerge: false(this repo's prior override of the plugin's own default), it does that bump on the dependent's own separate branch, not engine's. So the dependent'spackage.jsonends up requiring an engine version that exists nowhere: not locally (engine's bump lives on a different, unmerged branch), and not on npm (it hasn't published yet).npm cithen fails withETARGETuntil a human notices, manually walks engine's release through to publish, then updates the dependent's branch. That's exactly what ate hours across this session.merge: trueis the plugin's own purpose-built mechanism for this exact scenario: it combines a package with the dependents its own dependency-bump logic pulled in as candidates into one PR/commit. Engine's new version and its dependents' bumped ranges land together atomically -- npm workspaces then resolves@loopover/enginefrom the local checkout, which always satisfies the range regardless of npm registry publish timing or ordering. This eliminates the failure mode structurally instead of reacting to it after the fact.packages/loopover-ui-kithas no dependency edge to any other package in this repo, so it's never pulled into the merge and keeps its fully independent release cadence -- confirmed viagrep '@loopover' packages/loopover-ui-kit/package.jsonreturning nothing.Test plan
npm run actionlint-- cleannpm run typecheck-- clean (afternpm run build --workspace @loopover/engine)release-please-config.jsongoogleapis/release-please's own source (src/plugins/workspace.ts) thatmergedefaults totrueand controls exactly this: "If multiple in-scope packages are being updated, it will merge them into a single package [PR]" -- this repo had explicitly overridden that default tofalse