fix(release): auto-derive .release-please-manifest.json instead of hand-editing it#7102
Merged
Merged
Conversation
…nd-editing it #7100 fixed the immediate mismatch by hand-typing corrected version numbers into .release-please-manifest.json -- exactly the failure mode that caused the drift in the first place (a human-authored value instead of one derived from source of truth). This replaces that with a real mechanism: - scripts/sync-release-manifest.mjs treats each package's own package.json "version" as authoritative and syncs the manifest to match -- `npm run release-manifest:sync` is now the only supported way to fix drift, never a manual edit. - `npm run release-manifest:sync:check` (wired into both test:ci and .github/workflows/ci.yml, gated on backend/mcp/engine/miner/ui) fails CI the moment the manifest and a package.json disagree, instead of surfacing days later as release-please re-proposing an already-published version (#7086/#7087). - .release-please-manifest.json and release-please-config.json are now part of the `backend` path filter so editing either alone still triggers the check. Also corrects reference.md's CI check table, which still claimed manifest:drift-check/engine-parity:drift-check weren't wired into ci.yml -- stale since #7067 actually added them.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7102 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 692 692
Lines 68808 68808
Branches 18781 18781
=======================================
Hits 64511 64511
Misses 3302 3302
Partials 995 995
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#7100 fixed the immediate
.release-please-manifest.jsonmismatch by hand-typing corrected version numbers -- exactly the failure mode that caused the drift in the first place (a human-authored value instead of one derived from source of truth). This replaces that with a real mechanism, so it's a one-command fix from here on, never a manual edit:scripts/sync-release-manifest.mjstreats each package's ownpackage.json"version"as authoritative and syncs the manifest to match.npm run release-manifest:syncis now the supported way to fix drift.npm run release-manifest:sync:check-- wired into bothtest:ciand.github/workflows/ci.yml(gated onbackend/mcp/engine/miner/ui) -- fails CI the moment the manifest and a package'spackage.jsondisagree, instead of surfacing days later as release-please re-proposing an already-published version as a brand-new Release PR (what happened with chore(release): cut miner v3.1.1 #7086/chore(release): cut mcp v3.1.1 #7087)..release-please-manifest.jsonandrelease-please-config.jsonare now part of thebackendpath filter, so an edit to either alone still triggers the check.Also corrects
reference.md's CI check table, which still claimedmanifest:drift-check/engine-parity:drift-checkweren't wired intoci.yml-- stale since #7067 actually added them -- and adds table rows for all 5 checks that landed across #7067 and this PR.Test plan
npm run actionlint-- cleannpx vitest run test/unit/sync-release-manifest.test.ts-- 8/8 pass (pure-function + injected-io coverage mirroringsync-release-lockfile-versions.test.ts's established pattern)npm run typecheck-- clean (afternpm run build --workspace @loopover/engine)npm run release-manifest:sync:check-- passes against the real, already-correct manifest; manually verified it fails loudly when a version is hand-corrupted, then re-passes afternpm run release-manifest:syncnpm run docs:drift-check-- clean