Skip to content

fix(mcp): list maintain and contributor-profile in --help#7036

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
galuis116:fix/cli-help-missing-commands
Jul 17, 2026
Merged

fix(mcp): list maintain and contributor-profile in --help#7036
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
galuis116:fix/cli-help-missing-commands

Conversation

@galuis116

Copy link
Copy Markdown
Contributor

Summary

  • loopover-mcp --help (printHelp()) listed ~30 real, dispatched top-level commands but omitted two: maintain (dispatched with its own printMaintainHelp() covering 14 subcommands) and contributor-profile (contributorProfileCli, added by CLI mirror for loopover_get_contributor_profile #6737). A user running --help had no way to discover either command exists.
  • Added a maintain usage line following the existing entries' format, listing its subcommands and pointing to loopover-mcp maintain --help for the full detail (matching the issue's request not to duplicate printMaintainHelp()'s own listing).
  • Added a contributor-profile usage line in the same style as the neighboring decision-pack/repo-decision entries.
  • Added a regression test (test/unit/mcp-cli-help.test.ts) asserting both commands appear in --help output, and that the bare help command (an alias) shows the same banner.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves.

Closes #6991

Validation

  • git diff --check
  • npm run actionlint (no workflow changes in this PR)
  • npm run typecheck
  • npm run test:coverage (not applicable: packages/loopover-mcp/** is outside the vitest coverage collection scope per codecov.yml's documented src/**-scoped collection, same as every other CLI-only change in this file; the new mcp-cli-help.test.ts (3 tests) and the existing mcp-cli-completion-spec.test.ts/mcp-cli-basics.test.ts (34 tests) all pass locally)
  • npm run test:workers (not applicable to this change)
  • npm run build:mcp (not applicable to this change)
  • npm run test:mcp-pack (not applicable to this change)
  • npm run ui:openapi:check (no API/schema changes in this PR)
  • npm run ui:lint (no UI changes in this PR)
  • npm run ui:typecheck (no UI changes in this PR)
  • npm run ui:build (no UI changes in this PR)
  • npm audit --audit-level=moderate (no dependency changes in this PR)
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • This PR only touches packages/loopover-mcp/bin/loopover-mcp.js's static --help usage text plus a new test file -- a plain-text banner change with no branches, API surface, or dependency impact, so the checks above have no surface to exercise. npm run docs:drift-check and npm run command-reference:check were also run locally and pass.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. (N/A -- no auth/cookie/CORS/session changes; this is a static help-text change.)
  • API/OpenAPI/MCP behavior is updated and tested where needed. (N/A -- no behavior change, only discoverability of existing commands.)
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks. (N/A -- no UI changes in this PR.)
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots. (N/A -- this PR has no UI/visual surface; it's a CLI --help text change.)
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

Notes

  • No UI Evidence table: this PR changes a terminal --help usage banner, not a UI surface -- the new automated test (mcp-cli-help.test.ts) is the evidence that both commands are now listed.

printHelp() listed ~30 real top-level commands but omitted two dispatched ones: maintain (13-plus subcommands, its own printMaintainHelp()) and contributor-profile (added by JSONbored#6737). A user running loopover-mcp --help had no way to discover either command exists. Added a usage line for each, following the existing entries' formatting; maintain's line points to loopover-mcp maintain --help for the full subcommand list rather than duplicating it.
@galuis116
galuis116 requested a review from JSONbored as a code owner July 17, 2026 18:56
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.74%. Comparing base (a45625f) to head (f53f9aa).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7036   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files         692      692           
  Lines       68721    68721           
  Branches    18760    18760           
=======================================
  Hits        64424    64424           
  Misses       3302     3302           
  Partials      995      995           
Flag Coverage Δ
shard-1 43.81% <ø> (ø)
shard-2 36.91% <ø> (+0.06%) ⬆️
shard-3 33.30% <ø> (-0.07%) ⬇️
shard-4 33.91% <ø> (+<0.01%) ⬆️
shard-5 32.22% <ø> (ø)
shard-6 45.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 17, 2026
@loopover-orb

loopover-orb Bot commented Jul 17, 2026

Copy link
Copy Markdown

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-17 19:18:40 UTC

2 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · unknown

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a small, well-scoped fix that adds two missing usage lines to printHelp() for the maintain and contributor-profile commands, matching the existing format of neighboring entries and pointing to loopover-mcp maintain --help for subcommand detail rather than duplicating it. The change is purely additive to a help-text string and is accompanied by a focused regression test verifying both commands appear in --help output and that the bare help alias shows the same banner. The diff is minimal, low-risk, and directly closes the linked issue #6991.

Nits — 3 non-blocking
  • The long-file size smell for loopover-mcp.js (~4544 lines) predates this PR and isn't something this 2-line diff should be expected to fix, but it's worth tracking separately.
  • The test comment block in mcp-cli-help.test.ts duplicates prose from the PR description rather than being terse inline documentation.
  • Consider whether the growing printHelp() function itself should eventually be data-driven (e.g. an array of {cmd, usage} entries) to make future additions less error-prone, though that's out of scope here.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6991
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 1962 registered-repo PR(s), 1288 merged, 52 issue(s).
Contributor context ✅ Confirmed Gittensor contributor galuis116; Gittensor profile; 1962 PR(s), 52 issue(s).
Improvement ✅ Minor risk: clean · value: minor
Review context
  • Author: galuis116
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 1962 PR(s), 52 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Triage stale or unlinked PRs.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit b153047 into JSONbored:main Jul 17, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loopover-mcp --help omits the maintain and contributor-profile commands

2 participants