feat(mcp): add a loopover_get_maintainer_lane CLI mirror#6936
Closed
jeffrey701 wants to merge 1 commit into
Closed
feat(mcp): add a loopover_get_maintainer_lane CLI mirror#6936jeffrey701 wants to merge 1 commit into
jeffrey701 wants to merge 1 commit into
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Contributor
Author
|
Closing this immediately — it was built from a stale checkout and its whole-file blob would revert 158 lines of already-merged work ( Re-opening a clean version rebased on current |
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6739
Problem
The MCP tool
loopover_get_maintainer_lane(src/mcp/server.ts:1863) returns data that already ships as the.maintainerLanefield ofGET /v1/repos/:owner/:repo/intelligence. The CLI already proxies that exact same endpoint for the sibling field —loopover_get_label_auditpicks out.labelAudit, andloopover_get_burden_forecastpicks out its own field — butmaintainerLane, which sits right beside them in the samebuildRepoIntelligenceResponsepayload, had no CLI extraction at all.Fix
Add
registerStdioTool("loopover_get_maintainer_lane", { inputSchema: ownerRepoShape }, ...)toloopover-mcp.js, copyingloopover_get_label_audit's implementation byte-for-byte and returning{ repoFullName, generatedAt, maintainerLane: intelligence?.maintainerLane ?? null }, plus its registry entry (category: "maintainer") sostdioToolDescriptionresolves. No new route, no new fetch shape — it reuses the GET the sibling tools already make.Tests
New
test/unit/mcp-cli-maintainer-lane.test.ts(mirrorsmcp-cli-label-audit.test.ts):owner/repoto/v1/repos/:owner/:repo/intelligenceviaapiGetand returns the maintainer lane (public-safety regex asserted, as the sibling does);/intelligencerouteloopover_get_label_audituses, agrees with it onrepoFullName/generatedAtfor identical input, and each tool surfaces only its own slice (maintainerLanevslabelAudit).mcp-tool-rename-aliases.test.ts's two hard-coded tool-count assertions are updated 67 → 68 (the list is exact-count asserted in both the live server andloopover-mcp tools --json).Validation
npx vitest run test/unit/mcp-cli-maintainer-lane.test.ts→ 3/3 passnpx vitest run test/unit/mcp-tool-rename-aliases.test.ts→ 10/10 pass (68-tool count on both surfaces)test/unit/mcp-*.test.ts) → zero net-new failures: the failing set is byte-identical to the pristine baseline (25 pre-existing, Windows-only: npm-registry/telemetry/file-mode cases), with my new file adding 3 passes.npm run typecheck→ clean (0 errors);npm run build:mcp→ passes;npm run command-reference:check→ passes.