fix(miner): cover four omitted stores in doctor and migrate#6928
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
governor-state, attempt-log, replay-snapshot, and worktree-allocator were only migrated lazily; keep storeIntegrityChecks and migrate STORES in sync at eleven entries. Tests seed the four stores so the worktree-allocator open adapter is covered. Also bump the MCP discovery invariant 69→70 for JSONbored#6915's loopover_simulate_open_pr_pressure (merge CI pin drift on main). Closes JSONbored#6768 Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6928 +/- ##
==========================================
+ Coverage 89.39% 93.71% +4.31%
==========================================
Files 685 685
Lines 68357 68358 +1
Branches 18726 18726
==========================================
+ Hits 61108 64059 +2951
+ Misses 5497 3302 -2195
+ Partials 1752 997 -755
Flags with carried forward coverage won't be shown. Click here to find out more.
|
validate-code failed: resolveReplaySnapshotDbPath expects NodeJS.ProcessEnv. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid ProcessEnv-typed resolve helpers that reject the slim tempEnv object under the repo's strict Env typing; the uncovered patch line is the adapter. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-17 14:12:31 UTC
Review summary Nits — 5 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
governor-state,attempt-log,replay-snapshot, andworktree-allocatorto doctor'sstoreIntegrityChecksand migrate'sSTORES(eleven stores, keep lists in sync).worktree-allocatoropen adapter is executed (codecov/patch).loopover_tool count pin 69→70 after#6915registeredloopover_simulate_open_pr_pressure.Closes #6768
Test plan
runMigrateChecksreturns 11 skips on empty state; seeded four stores reportup-to-datevalidate-tests+codecov/patch≥ 99%Supersedes closed #6922 (auto-closed on prior codecov miss; this PR includes the coverage fix up front).