docs(selfhost): fix stale gittensory-selfhost self-host doc defaults#6826
Merged
Conversation
The OTEL_SERVICE_NAME default (src/selfhost/otel.ts) and the Sentry cron monitor slug format (resolveSentryMonitorSlug, src/selfhost/sentry.ts) have both emitted loopover-selfhost-prefixed values for a while now, but two self-hosting doc paragraphs still described the pre-rename gittensory-selfhost defaults. Extends the existing #5937 rename-residue regression test with both cases. Leaves the SENTRY_RELEASE default in scripts/deploy-selfhost-prebuilt.sh (and its doc mention) untouched -- test/unit/selfhost-sentry-release.test.ts pins that literal deliberately, unlike the monitor slug.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Bundle ReportChanges will decrease total bundle size by 4.43kB (-0.06%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: loopover-uiAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6826 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 683 683
Lines 68148 68148
Branches 18703 18703
=======================================
Hits 63812 63812
Misses 3350 3350
Partials 986 986
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self-hosting-configuration.mdx: documented theOTEL_SERVICE_NAMEdefault asgittensory-selfhost, butsrc/selfhost/otel.tshas fallen back toloopover-selfhostfor a while now.self-hosting-operations.mdx: documented the Sentry cron monitor slug format asgittensory-selfhost-{environment}-{loop}, butresolveSentryMonitorSlug(src/selfhost/sentry.ts) has emittedloopover-selfhost-...slugs for a while now (also covered bytest/unit/selfhost-sentry.test.ts's existing assertions).#5937rename-residue regression test (test/unit/self-host-ops-rename-residue.test.ts) with both cases so this doesn't drift again.SENTRY_RELEASEdefault inscripts/deploy-selfhost-prebuilt.sh(gittensory-selfhost@<sha>) or its doc mention --test/unit/selfhost-sentry-release.test.tspins that exact literal on purpose, unlike the monitor slug. Verified this is intentional (not drift) before leaving it alone.Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.gittensoryreferences left from the ongoing rebrand, not a contributor-facing fix tied to a filed issue.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally (docs + test file only; nosrc/**lines changed, so Codecov patch coverage does not apply)npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderatenpm run test:cirun green end to end (all 18001 tests, 13 intentionally skipped, 0 failed)Safety
UI Evidencesection -- N/A, this is a docs-content text fix (a paragraph on an existing docs page), not a visual/layout change.Notes
gittensoryreferences (~410 files) left over from the rebrand, split by area per repo convention (small, focused PRs). This one covers self-hosting docs describing OTEL/Sentry monitor defaults specifically.