Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions packages/loopover-engine/src/track-record-summary.ts
Original file line number Diff line number Diff line change
Expand Up @@ -423,26 +423,34 @@ export function shouldIncludeTrackRecordSummary(
*/
export function renderTrackRecordSummaryMarkdown(summary: TrackRecordSummary): string {
if (!summary.enabled) return "";
const lines = [
// The login is the contributor's own IDENTITY, not computed content, and a hyphen is a legal GitHub username
// character — so a real login like `team-wallet`/`payout-bot` trips the word-boundary blocklist and used to
// throw on that contributor's own summary (#6772). The blocklist exists to catch leaked COMPUTED fields, not
// to validate identity, so the login line is composed after the scan and excluded from it. Everything the
// blocklist is actually for (labels, evidence, counts) still goes through assertPublicSummaryText below, so a
// genuinely-injected blocked term in a computed field still fails closed exactly as before.
const scannedLines = [
"### Public contributor record",
"",
`- GitHub login: ${markdownSafe(summary.login)}`,
`- Resolved public PRs: ${summary.outcomes.resolved} (${summary.outcomes.merged} merged, ${summary.outcomes.closedWithoutMerge} closed without merge)`,
`- Public merge rate: ${summary.mergeRate.label}`,
`- Public tenure: ${summary.tenure.label}`,
`- Public conduct record: ${summary.incidents.label}`,
];

if (summary.outcomes.openIgnored > 0) {
lines.push(`- Open PRs ignored for rate: ${summary.outcomes.openIgnored}`);
scannedLines.push(`- Open PRs ignored for rate: ${summary.outcomes.openIgnored}`);
}
if (summary.incidents.hasPublicIncident && summary.incidents.evidenceUrls.length > 0) {
lines.push(
scannedLines.push(
`- Public evidence: ${summary.incidents.evidenceUrls.map((url) => markdownSafe(url)).join(", ")}`,
);
}

const rendered = `${lines.join("\n")}\n`;
assertPublicSummaryText(rendered);
return rendered;
assertPublicSummaryText(`${scannedLines.join("\n")}\n`);

// Re-insert the identity line in its original position (right after the heading's blank line).
const lines = [...scannedLines];
lines.splice(2, 0, `- GitHub login: ${markdownSafe(summary.login)}`);
return `${lines.join("\n")}\n`;
}
67 changes: 67 additions & 0 deletions test/unit/track-record-summary-login-blocklist.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
import { describe, expect, it } from "vitest";
import {
computeTrackRecordSummary,
renderTrackRecordSummaryMarkdown,
} from "../../packages/loopover-engine/src/track-record-summary";

const NOW = "2026-07-04T18:00:00.000Z";

function summaryFor(login: string, incidentLabelSource?: string) {
return computeTrackRecordSummary({
login,
now: NOW,
config: { includeTrackRecordSummary: true, warnings: [] },
outcomes: [
{ id: "pr-1", repoFullName: "owner/repo", authorLogin: login.toLowerCase(), state: "merged", createdAt: "2026-06-01T00:00:00Z" },
// An open PR too, so the `openIgnored > 0` line the scan also builds is exercised.
{ id: "pr-2", repoFullName: "owner/repo", authorLogin: login.toLowerCase(), state: "open", createdAt: "2026-07-01T00:00:00Z" },
],
...(incidentLabelSource
? { incidents: [{ login: login.toLowerCase(), kind: "moderation", publicEvidenceUrl: incidentLabelSource }] }
: {}),
});
}

// #6772: PUBLIC_FIELD_BLOCKLIST exists to catch leaked COMPUTED fields. A hyphen is a legal GitHub username
// character, so a real login like `team-wallet` matches `/\bwallet\b/iu` as a whole word and used to throw on
// that contributor's OWN summary. The identity line is now excluded from the scan.
describe("renderTrackRecordSummaryMarkdown login vs the public-field blocklist (#6772)", () => {
it("REGRESSION: renders instead of throwing for a login containing a blocklisted word", () => {
for (const login of ["team-wallet", "payout-bot", "coldkey-labs", "hotkey-ops", "reward-guild", "ranking-labs"]) {
const markdown = renderTrackRecordSummaryMarkdown(summaryFor(login));
expect(markdown).toContain(`- GitHub login: ${login}`);
}
});

it("keeps the login on its original line, right after the heading's blank line", () => {
const lines = renderTrackRecordSummaryMarkdown(summaryFor("team-wallet")).split("\n");
expect(lines[0]).toBe("### Public contributor record");
expect(lines[1]).toBe("");
expect(lines[2]).toBe("- GitHub login: team-wallet");
expect(lines[3]).toContain("- Resolved public PRs:");
});

it("an ordinary login still renders byte-identically (no positional drift, escaping intact)", () => {
const markdown = renderTrackRecordSummaryMarkdown(summaryFor("Miner_Name"));
// Normalized to lowercase and markdown-escaped, exactly as before this change.
expect(markdown).toContain("- GitHub login: miner\\_name");
expect(markdown.startsWith("### Public contributor record\n\n- GitHub login:")).toBe(true);
});

it("still fails closed when a COMPUTED field carries a blocked term (injection guard intact)", () => {
// The evidence URL is computed/leakable content, not identity — it must still trip the blocklist.
expect(() => renderTrackRecordSummaryMarkdown(summaryFor("miner", "http://example.test/wallet"))).toThrow(
/blocked public field/i,
);
});

it("a disabled summary still renders empty (unchanged short-circuit)", () => {
const disabled = computeTrackRecordSummary({
login: "team-wallet",
now: NOW,
config: { includeTrackRecordSummary: false, warnings: [] },
outcomes: [],
});
expect(renderTrackRecordSummaryMarkdown(disabled)).toBe("");
});
});