Skip to content

docs(engine): correct normalizeNonNegativeInteger's floor in its doc comment (#6775) #6800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 17, 2026
+3 −1
Merged

docs(engine): correct normalizeNonNegativeInteger's floor in its doc comment (#6775) #6800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/loopover-engine/src/ams-policy-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ function normalizePositiveNumber(value: unknown, field: string, fallback: number
}

/** Like normalizePositiveNumber, but floors to a whole count -- for fields that are semantically integer
* counts (an iteration/turn budget), matching MinerGoalSpec's own normalizePositiveInteger convention. */
* counts (an iteration/turn budget). Its floor is >= 0: unlike MinerGoalSpec's normalizePositiveInteger
* (which rejects anything < 1 after flooring), 0 is deliberately accepted here (see the parser test's
* zero-budget case) -- a 0 budget is a meaningful "do nothing" setting, not a malformed value. */
function normalizeNonNegativeInteger(value: unknown, field: string, fallback: number, warnings: string[]): number {
const normalized = normalizePositiveNumber(value, field, fallback, warnings);
return Math.floor(normalized);
Expand Down