chore(ci): add a drift guardrail against new gittensory branding#6788
Conversation
This session found and fixed real behavioral drift left over from the loopover rebrand -- a hardcoded MCP resource URI (#6786), a Qdrant collection default, and metric names that only got caught by manual investigation. scripts/check-branding-drift.mjs snapshots today's known "gittensory" mentions in executable src/ and packages/*/{bin,lib,src} code (test/**, docs, and CHANGELOGs are excluded -- those legitimately reference the rename permanently) and fails CI if a file's count rises without the baseline being regenerated, the same generated-artifact convention this repo already uses for openapi.json and cf-typegen. Wired into npm run test:ci via a new branding-drift:check script; branding-drift:update regenerates the baseline for an intentional change.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | f4c9a2c | Commit Preview URL Branch Preview URL |
Jul 17 2026, 06:40 AM |
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6788 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 683 683
Lines 68148 68148
Branches 18703 18703
=======================================
Hits 63812 63812
Misses 3350 3350
Partials 986 986
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-17 06:46:17 UTC
Review summary Nits — 1 non-blocking
Concerns raised — review before merging
📋 Copy for AI agents — paste into your coding agentDecision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
JSONbored#6786 removed the last 3 gittensory references in loopover-mcp.js, routes.ts, and enrichment-analyzers-taxonomy.ts; JSONbored#6788's baseline (merged around the same time) predated that fix, so main's own branding-drift:check has been red since both landed.
Summary
scripts/check-branding-drift.mjs: snapshots today's knowngittensorymentions (line-count granularity viagit grep -c) in executable code undersrc/**and each workspace package'sbin/,lib/,src/,scripts/dirs.test/**, docs, and CHANGELOGs are deliberately excluded — a Sentry ticket ID likeGITTENSORY-K/8, a stable PR-comment marker, or a DBsourcecolumn value joined against historical rows is a permanent, intentional reference in those files, not drift.scripts/branding-drift-baseline.json): a file's count rising means new drift landed; falling means a cleanup landed without regenerating the baseline. Either way,npm run branding-drift:updateregenerates it — same generated-artifact convention this repo already uses foropenapi.json/cf-typegen/migrations, rather than a new pattern.npm run test:civiabranding-drift:check.Scope
Validation
npx vitest run test/unit/check-branding-drift-script.test.ts— 12/12 passingnpm run branding-drift:check— passes against the committed baselinenpm run typecheck— cleangittensorystring to a scoped file, confirmed the check fails with a clear message, reverted, confirmed it passes againNote
This branch's baseline was generated before #6786 (the enrichment-analyzers URI fix) merged, so it still counts
packages/loopover-mcp/bin/loopover-mcp.jsat its pre-fix value (5, not 3). Once #6786 merges, rebasing this branch and runningnpm run branding-drift:updatebefore merge will pick up the corrected count — the check's own error message explains this exact situation if it's not done first.