docs(review): stop claiming the self-improve D1 tables don't exist

[luciferlive112116]

Summary

Closes #6195

src/review/ops-wire.ts's header explained why the auto-tune/auto-apply loop stays deferred:

it needs the tunables_overrides / _shadow / override_audit D1 tables (none of which exist in loopover's migrations yet) plus a careful soak/promote design

Verified against the repo — that premise is stale, and the comment contradicted itself:

• Finish the settings/ slice extraction #4879's migrations/0047_self_improve_tunables.sql creates all three: tunables_overrides (line 22), tunables_overrides_shadow (line 33), override_audit (line 44).
• src/review/auto-apply.ts already implements the store against them — loadOverride/writeLiveOverride/deleteLiveOverride, loadShadowOverride/writeShadowOverride/deleteShadowOverride, recordOverrideAudit/listOverrideAudit — which the migration's own header documents table-by-table.
• The same sentence already acknowledged that store exists ("The ported pure logic + D1 store already exist in src/review/auto-apply.ts") while claiming its tables did not.

Fix: remove only the false premise. The deferred conclusion is still correct, so it stays — and the comment now names what the real remaining blocker actually is: the careful soak/promote design, i.e. the shadow-soak-then-promote lifecycle auto-apply.ts's own isStrictlyTightening / evaluateShadowPromotion already anticipate (both verified to exist, at auto-apply.ts:123 and :145). A reader is no longer misled into thinking the D1 schema is what's missing.

Scope

• Conventional Commit title (docs(review): …).
• Comment-only, exactly as the issue requires ("No code behavior change"). Mechanically verified: every added/removed line in the diff is a comment line.
• Keeps the comment's still-true point that the module remains deliberately read-only — only the stale premise is corrected, not the conclusion.
• Follows CONTRIBUTING.md; no site//CNAME/lovable; no changelog edit.
• Linked open issue (Closes docs(review): ops-wire.ts's comment claims the tunables_overrides/_shadow/override_audit D1 tables don't exist yet — they already do (#4879) #6195, above).

Validation

• git diff --check clean.
• npm run typecheck — exit 0.
• No coverage surface: the diff changes zero executable lines, so no line/branch coverage can move. Verified mechanically over the whole diff, not by inspection.
• Every claim in the replacement text was verified against the repo before writing it — the migration line numbers, the store functions, and the two symbols now cited (isStrictlyTightening, evaluateShadowPromotion) all exist.
• Rebased onto current main.

If any required check was skipped, explain why:

• Full test:ci not run end-to-end locally (Linux-only steps on Windows). Nothing executable changed, so no suite's behavior is affected.

Safety

• No secrets, wallets, hotkeys, trust scores, rewards, private rankings, or private maintainer evidence.
• No auth/cookie/CORS/GitHub App/session change.
• No behavior change of any kind — comment text only. No API/OpenAPI/MCP change, no schema change, no generated artifact affected.
• Does not weaken a safety note: the module stays documented as READ-ONLY observability, and the deferral of the config-mutation loop stays in place — the correction only re-points the reason at the real blocker.
• No UI changes; no changelog edit.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.35%. Comparing base (2af2da3) to head (c17e5c9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6232   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files         598      598           
  Lines       47102    47102           
  Branches    14988    14988           
=======================================
  Hits        44913    44913           
  Misses       1464     1464           
  Partials      725      725           

Flag	Coverage Δ
shard-1	43.98% <ø> (-0.05%)	⬇️
shard-2	36.78% <ø> (+0.11%)	⬆️
shard-3	32.23% <ø> (+<0.01%)	⬆️
shard-4	33.96% <ø> (-0.45%)	⬇️
shard-5	31.73% <ø> (+0.12%)	⬆️
shard-6	45.22% <ø> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/review/ops-wire.ts	98.50% <ø> (ø)

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-15 23:39:14 UTC}

1 file · 1 AI reviewer · no blockers · readiness 77/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This is a comment-only correction in src/review/ops-wire.ts that removes a stale, self-contradicting premise (claiming the tunables_overrides/_shadow/override_audit D1 tables don't exist) while keeping the still-valid conclusion that the auto-apply loop remains deliberately deferred pending a soak/promote design. The diff touches only comment lines, matches the PR's stated scope exactly, and correctly redirects the reader to the real remaining blocker.

Nits — 3 non-blocking

• The comment now references isStrictlyTightening/evaluateShadowPromotion by name without line numbers; a `file:line` pointer (as the PR description itself gives, auto-apply.ts:123/:145) would make it more durable to future refactors.
• Consider adding the `auto-apply.ts:123`/`:145` line references directly in the comment itself, not just the PR description, so future readers get the same traceability.
• Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#6195
Related work	⚠️ 2 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 131 registered-repo PR(s), 70 merged, 32 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	luciferlive112116; Gittensor profile; 131 PR(s), 32 issue(s).
Improvement	ℹ️ None detected	risk: low · value: none · LLM: minor

Linked issue satisfaction

Addressed
The diff directly removes the stale 'tables don't exist yet' premise in ops-wire.ts's comment, cites the actual migration, and preserves the still-true deferred/read-only conclusion pending soak/promote design, exactly matching the issue's ask.

Review context

• Author: luciferlive112116
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, JavaScript, MDX, Rust, TypeScript
• Official Gittensor activity: 131 PR(s), 32 issue(s).
• Related work: Items reference the same linked issue docs(review): ops-wire.ts's comment claims the tunables_overrides/_shadow/override_audit D1 tables don't exist yet — they already do (#4879) #6195. (issue #6195)
• Related work: Open PR work references issue docs(review): ops-wire.ts's comment claims the tunables_overrides/_shadow/override_audit D1 tables don't exist yet — they already do (#4879) #6195. (issue #6195)

Contributor next steps

• Start here: Review top overlaps.
• Then work through the remaining 3 steps in the Signals table above.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.