chore(release): cut miner v2.0.0#5730
Merged
JSONbored merged 3 commits intoJul 14, 2026
Merged
Conversation
| }, | ||
| "dependencies": { | ||
| "@loopover/engine": "^2.0.0", | ||
| "@loopover/engine": "*", |
Contributor
There was a problem hiding this comment.
P1: Dependency uses wildcard version allowing any package version
"@loopover/engine" dependency changed from "^2.0.0" to "*" allowing any version.
Revert to a concrete version range or exact version instead of wildcard.
AI prompt
Check if this security scanner issue is valid. If so, understand the root cause and fix it. If appropriate, update or add tests. Keep the change focused and preserve intended behavior.
<file name="packages/gittensory-miner/package.json">
<violation number="1" location="packages/gittensory-miner/package.json:44">
<priority>P1</priority>
<title>Dependency uses wildcard version allowing any package version</title>
<evidence>The PR changes @loopover/engine from "^2.0.0" to "*" in the dependencies section. A wildcard version specifier allows npm/yarn to install any published version of the package, including future malicious or compromised versions, removing all version-range protections.</evidence>
<recommendation>Revert to a concrete version range such as "^2.0.0" or pin to an exact version (e.g., "2.0.0") and update the lockfile accordingly.</recommendation>
</violation>
</file>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5730 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 581 581
Lines 46179 46179
Branches 14811 14811
=======================================
Hits 43902 43902
Misses 1516 1516
Partials 761 761
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
release-please's regeneration of this branch (cutting v2.0.0 for the CLI binary rename) silently reverted the @loopover/engine dependency from the ^2.0.0 constraint landed in #5729 back to "*", removing semver protection -- flagged by the repo's security scanner on this PR. "*" would silently accept any future engine version, including a compromised publish or a major version that removes DEFAULT_DENY_RULES again (the export miner's own lib/deny-hooks.js genuinely requires as of engine 2.0.0). Also fixes test/unit/miner-cli.test.ts's two hardcoded version assertions ("1.0.0"), stale against this cut's real 2.0.0 (a genuine breaking change: the CLI binary rename).
JSONbored
approved these changes
Jul 14, 2026
Contributor
Author
|
🤖 Created releases: 🌻 |
4 tasks
JSONbored
added a commit
that referenced
this pull request
Jul 14, 2026
…anges (#5740) release-please's node-workspace plugin defaults to always-link-local: true, which force-rewrites every workspace-internal dependency's semver range on every regeneration of a release branch -- even when the current range already satisfies the sibling's version. This has repeatedly clobbered deliberate, manually-set constraints on @loopover/miner's and @loopover/mcp's @loopover/engine dependency back to a bare "*" (most recently caught by the repo's security scanner on #5730, PR #5729 before that), and separately generated a string of "empty" release PRs (mcp-v0.8.1, mcp-v1.0.1, miner-v2.0.1) that exist purely to speculatively cross-bump a dependency range ahead of the sibling's actual publish, with no real content of their own. Setting always-link-local: false (a documented top-level manifest option, confirmed against release-please's own JSON schema) makes the plugin only touch a workspace dependency when the CURRENT range no longer covers the sibling's version -- i.e. only for a genuine breaking change, which is exactly when a deliberate, manually-verified bump is warranted anyway (the judgment call this session has been making by hand every time this came up). Also fixes apps/gittensory-ui/src/lib/mcp-package.ts's MCP_PACKAGE_KNOWN_LATEST_VERSION, stale against mcp's real just-published 0.9.0 (unrelated to the config change, but blocking this branch's own gate via ui:version-audit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
2.0.0 (2026-07-14)
⚠ BREAKING CHANGES
gittensory-miner,gittensory-miner-mcp, andgittensory-mcpno longer exist as installed binaries; useloopover-miner,loopover-miner-mcp, andloopover-mcp. No dual-read/alias, per the epic's full-cutover mandate. A global npm install/link of the old package names must be reinstalled.Features
Fixes
This PR was generated with Release Please. See documentation.