feat(miner): add --dry-run to governor pause/resume#5553
Merged
Conversation
Completes the --dry-run coverage started in #5527/#5532: governor pause/resume (#4851) are the last local-mutating commands in the CLI. Reports what would happen and returns before opening governor-state, matching every other mutating command's dry-run pattern. governor status is read-only and needs no dry-run. Closes #4847
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | ea7fde2 | Commit Preview URL Branch Preview URL |
Jul 13 2026, 04:59 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5553 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 570 570
Lines 45325 45351 +26
Branches 14675 14675
=======================================
+ Hits 43020 43046 +26
Misses 1571 1571
Partials 734 734
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
loopover-orb
Bot
added
the
gittensor:feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dry-runcoverage across the miner CLI, started in feat(miner): add --dry-run to attempt and loop #5527 (attempt/loop) and feat(miner): add --dry-run to the remaining local-mutating CLI commands #5532 (queue/claim/state/discover/orb export/manage poll):governor pause/governor resume(Build a governor pause/resume control surface #4851, merged in feat(miner): build a governor pause/resume control surface #5523) were the last two local-mutating commands without it.governor-stateat all (opening a not-yet-existing SQLite store file is itself a write), reporting what would happen via a{ outcome: "dry_run", ... }JSON shape or a plain-textDRY RUN: ...message, matching every other command's existing pattern.governor statusis read-only and needs no dry-run — untouched.Closes #4847 (every mutating command in the CLI now honors
--dry-run).Test plan
npx tsc --noEmit --incremental falsenpx vitest run test/unit test/contract(806 files, 15664 tests passed, 2 pre-existing skips)npm run test:coverage(unsharded) — 100% patch coverage (lines + branches) on both changed files, verified againstgit diff --unified=0hunksnpm run docs:drift-check,manifest:drift-check,engine-parity:drift-check,miner:env-reference:checknpm audit --audit-level=moderate— 0 vulnerabilitiesnpm run build(packages/gittensory-miner) —node --checkon all lib filesorigin/main(no rebase needed)