feat(miner): publish operational files (DEPLOYMENT.md, docs, Dockerfile, schema) in the npm package (#4874)#5528
Conversation
…files This commit enhances the gittensory-miner package by adding new operational files to the package.json, including "docs", "schema", "DEPLOYMENT.md", and "Dockerfile". The validation script has been updated to ensure these files are present, preventing silent omissions. Additionally, unit tests have been added to verify the presence of these files, ensuring compliance with the new structure. Closes JSONbored#4874.
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5528 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 566 566
Lines 45065 45065
Branches 14675 14675
=======================================
Hits 42718 42718
Misses 1613 1613
Partials 734 734
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-13 04:03:54 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 6 non-blocking
Flagged checks (non-blocking)
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
The published
@jsonbored/gittensory-minerpackage'sfileslist was["bin", "lib", "expected-engine.version"], so annpm install -guser — the README's own quickstart path — had no access to the package's operational material (DEPLOYMENT.md, thedocs/directory, theDockerfile, or theschema/directory) without separately visiting the GitHub repo.This ships that material with the package:
package.json— addsdocs,schema,DEPLOYMENT.md, andDockerfiletofiles.scripts/check-miner-package.mjs(thetest:miner-packgate, an allowlist over the packed file set) — extendsALLOWEDto permit those paths (DEPLOYMENT.md,Dockerfile,docs/*.md,schema/*.json), addsDEPLOYMENT.md/Dockerfile/schema/miner-goal-spec.schema.jsontoREQUIRED, and adds adocs/*.mdpresence check — so the operational files are now a published guarantee, asserted on every pack, not just a one-time addition that could silently regress..mdor nested docs file is still rejected).Verified against the real
npm pack --dry-runoutput: all four categories now appear in the packed set and pass the check. The allowlist is deliberately kept narrow (onlydocs/*.mdandschema/*.json, not arbitrary nested paths), consistent with the existinglib/flattening discipline.Closes #4874
Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run typechecknpm run test:miner-packlogic verified: the realnpm pack --dry-runfile list (205 files) fed throughcheck-miner-package.mjspasses and includesDEPLOYMENT.md,Dockerfile,docs/*.md, andschema/miner-goal-spec.schema.json. Unit tests incheck-miner-package.test.ts(fixed 1 order-affected case + 4 new operational-file cases) pass; the sole failing case (passes on the real workspace package) is a pre-existing Windows-onlynpm-spawn issue that fails identically onmainand passes on CI/Linux.npm run test:workers·build:mcp·ui:*— N/A (miner packagefiles+ its pack-check script/tests only).If any required check was skipped, explain why:
Change is confined to the miner package's
fileslist, thetest:miner-packcheck script, and that script's unit tests. No workersrc/**, workflow, MCP, OpenAPI, or UI surface is touched.Safety
UI Evidence
N/A — packaging change, no UI.
Notes
REQUIRED(not justALLOWED) so the pack check now fails if any of them is ever dropped from the package again — turning Publish operational files with the npm package #4874 into an enforced invariant rather than a one-off fix.README.mdis already published (npm includes it by default); only the four categories the issue named were missing.