Register a stake pool's BLS voting key - #1423
Draft
ch1bo wants to merge 2 commits into
Draft
Conversation
Adds --bls-signing-key-file to 'stake-pool registration-certificate'. The option is era-gated: mandatory from Dijkstra onwards and not offered at all in Conway or earlier, so existing invocations are unaffected. The signing key is read as a text envelope and turned into the registered verification key plus proof of possession via 'createBlsKeyRegistration'. Genesis pool parameters get 'sppBlsKey = SNothing', which cardano-ledger-core 1.22 requires at every StakePoolParams construction site, and the compatible pre-Dijkstra path sets 'stakePoolBlsKey = Nothing'. Note the option is not yet reachable: master only exposes 'node' under the 'dijkstra' subcommand, so 'pStakePoolCmds' is instantiated at ConwayEra only and the Dijkstra branch of the parser is dormant. It activates as soon as the era-based stake-pool commands are wired up for Dijkstra. Golden help output is therefore unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Until now the `dijkstra` subcommand only offered `node`, so `stake-pool registration-certificate` was unreachable there and the era-gated `--bls-signing-key-file` could never fire. A pool's BLS voting key is only registrable from Dijkstra onwards, so the command has to be reachable for the key to be registrable at all. `runCmds` is already era-polymorphic and `runAnyEraCommand` already wraps it in `obtainCommonConstraints`, so no run-side change is needed -- this is purely parser wiring. Introduces `pDijkstraCmds` as the explicit list of command groups vetted for the new era, rather than switching Dijkstra over to the full `pCmds`. The remaining groups (query, transaction, genesis, governance, ...) can be added as each is checked over. New golden help files are required and must be generated with CREATE_GOLDEN_FILES=1. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--bls-signing-key-filetostake-pool registration-certificate.The option is era-gated: mandatory from Dijkstra onwards and not offered
at all in Conway or earlier, so existing invocations are unaffected. The
signing key is read as a text envelope and turned into the registered
verification key plus proof of possession via
createBlsKeyRegistration.Genesis pool parameters get
sppBlsKey = SNothing, whichcardano-ledger-core 1.22requires at everyStakePoolParamsconstructionsite, and the compatible pre-Dijkstra path sets
stakePoolBlsKey = Nothing.Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist
.changes/