ci: support CUDA 13.0 Docker builds and publishing - #4817
Open
lvhan028 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CI and internal build guidance to support building and publishing LMDeploy Docker images for CUDA 13.0 alongside CUDA 12.8, using canonical Docker build targets (cu130 / cu128) while keeping public tags (cu13.0 / cu12.8) consistent.
Changes:
- Update Docker CI workflows to build/test and publish CUDA 13.0 (
cu130) and CUDA 12.8 (cu128) variants. - Adjust Docker publish tagging logic to use separate “build target” vs “tag suffix” values.
- Refresh manywheel builder/wheel README and the internal
docker-buildskill documentation with CUDA 13.0 examples.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| builder/manywheel/README.md | Updates documentation for building/pushing builder images and building CUDA 13.0 wheels. |
| .github/workflows/test_docker.yml | Tests Docker builds across cu130 and cu128 build targets. |
| .github/workflows/docker.yml | Publishes Docker images for CUDA 13.0/12.8 using canonical build targets and versioned tags. |
| .claude/skills/docker-build/SKILL.md | Updates internal build instructions to map public CUDA variants to canonical Docker stage targets. |
Suppressed comments (1)
builder/manywheel/README.md:22
- This section describes selecting a CUDA version, but the example uses
GPU_ARCH_VERSION(the variable consumed bybuild_lmdeploy_builder.sh). Adding a short note here would reduce confusion for users who look forCUDA_VERSION.
For custom builds with specific manylinux and CUDA versions:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ./build_all_lmdeploy_builders.sh | ||
|
|
||
| # Build and push images (for CI/CD) | ||
| # Build and push the image (for CI/CD) |
Comment on lines
+42
to
+43
| Do not pass `cu13.0` or `cu12.8` directly to `docker/Dockerfile`. Its | ||
| canonical stage names are `cu130` and `cu128`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.