Repository navigation
refactor: replace null-forgiving operators with checked alternatives - #1646
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes null-forgiving operators (
!) where flow analysis, a checked throw, or the TUnitIsNotNull()return value can express the invariant. No behaviour change in production paths.Replacement patterns
!removed (flow analysis already proves non-null)HomeController(siteMapping),ServiceCollectionExtensions.ResolveLocalEndpointBookSearchTool(_SearchService is not null)?? throw new InvalidOperationException("...")BookContentTool,AISearchService(MaxBy),ServiceCollectionExtensions(connection string),RequiresLinuxContainersAttribute(Process.Start; already caught by the existingInvalidOperationExceptionfilter)?? string.EmptyReferralTrackingMiddleware(QueryString.Value)await Assert.That(x).IsNotNull()McpApiTokenServiceTests,LocalChatServiceTests,PwnedPasswordValidatorTests!intentionally keptDbSet<T> ... = null!inEssentialCSharpWebContext(framework-assigned).get => _Input!;in 14 Identity Razor Pages (model-bound[BindProperty]backing field; framework-assigned).null!arguments in tests that intentionally pass null to exercise argument validation or satisfy mocked constructors (PwnedPasswordTests,PwnedPasswordValidatorTests,SiteMappingTests,AIChatServiceModerationTests).Verification
dotnet build EssentialCSharp.Web.slnx -c Release /p:AccessToNugetFeed=false: 0 warnings, 0 errorsEssentialCSharp.Web.Tests: 202 passedEssentialCSharp.Chat.Tests: 41 passed