Allow single plot areas in plot info by name - #4924
Open
tantaf123 wants to merge 1 commit into
Open
Conversation
Contributor
|
While I like the idea I wonder if this should be held off until v8 when @Citymonstret rewrites the database schema. |
Author
|
That makes sense. My main goal here was to avoid changing the underlying
PlotId/database representation and only use the existing single-area name
as a human-facing identifier for /plot info. If v8 is the better place for
this though, I’m happy for it to wait.
… Message ID: ***@***.***
com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Single-plot areas internally use the plot ID
1;1, which can make multiple named single areas difficult to distinguish when using/plot info.This change allows named single-plot areas to be resolved by their area name when using
/plot info.For example, a single area named
apple_housecan be queried using:/plot info apple_houseFor named single-plot areas, the area name is also displayed instead of the generic
1;1identifier in the unclaimed plot information message.Normal plot IDs and aliases continue to use the existing resolution behaviour.
Submitter Checklist