fix: improve lock and sync when calling and trimming#3543
Open
dordsor21 wants to merge 1 commit into
Open
Conversation
Member
dordsor21
commented
May 24, 2026
dordsor21
commented
- also fix error when editing newly generated chunks due to postprocessgen not having been completed
- fixes Plugin "stopping" to work. #3490
- also fix error when editing newly generated chunks due to postprocessgen not having been completed - fixes #3490
PierreSchwang
approved these changes
May 25, 2026
Member
PierreSchwang
left a comment
PierreSchwang
left a comment
There was a problem hiding this comment.
Untested, but looks reasonable so far
SirYwell
requested changes
May 25, 2026
Comment on lines
+156
to
+160
| fieldPendingBlockEntities = ChunkAccess.class.getDeclaredField(Refraction.pickName( | ||
| "pendingBlockEntities", | ||
| "i" | ||
| ) | ||
| ); |
Member
There was a problem hiding this comment.
There shouldn't be any obfuscation anymore, right?
Member
Author
There was a problem hiding this comment.
No idea, I was just going along with everything... If it's been removed we can clean up a bunch of this class I guess? (This field is both paper and spigot fwiw)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.