Skip to content

[MAINT] Do not use copyright year ranges#2319

Open
ndgrigorian wants to merge 2 commits into
masterfrom
use-2020-as-copyright-year
Open

[MAINT] Do not use copyright year ranges#2319
ndgrigorian wants to merge 2 commits into
masterfrom
use-2020-as-copyright-year

Conversation

@ndgrigorian
Copy link
Copy Markdown
Collaborator

@ndgrigorian ndgrigorian commented May 26, 2026

This PR undoes use of copyright year ranges, using only the file creation year

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link
Copy Markdown

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 26, 2026

Coverage Status

coverage: 75.39%. remained the same — use-2020-as-copyright-year into master

@vlad-perevezentsev
Copy link
Copy Markdown
Collaborator

If we are switching to Copyright [yyyy] [name of copyright owner] format following the Apache License example could you also update sycl.pxd, _numpy_warnings.py and the remaining files in examples/c/ so that all copyright headers use the same style?

@ndgrigorian ndgrigorian force-pushed the use-2020-as-copyright-year branch from 1ce4d00 to e4cc595 Compare June 2, 2026 20:06
@ndgrigorian
Copy link
Copy Markdown
Collaborator Author

@vlad-perevezentsev
applied changes to those files

@vlad-perevezentsev
Copy link
Copy Markdown
Collaborator

@ndgrigorian Overall, LGTM.
But I am a bit concerned that for some files the copyright year does not match the file creation year probably because the copyright header was copied from existing files in the past.

I think the year should correspond to the year when the file was created.
For example, if _sycl_timer.py was introduced in 2021 then it should use Copyright 2021 Intel Corporation

Since checking this manually is quite time-consuming, I asked claude to analyze the file history.
Here are the results grouped by year:

copyright_years.md

@ndgrigorian
Copy link
Copy Markdown
Collaborator Author

copyright_years.md

this change is fine with me, my only thought was that we could move to a universal copyright date, but I think it would make sense to just use file creation year as well. I'll update the PR.

@ndgrigorian ndgrigorian changed the title [MAINT] Use 2020 as copyright year [MAINT] Do not use copyright year ranges Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants