Skip to content

chore: bump waveflow-core rev + simplify rename handler - #7

Merged
InstaZDLL merged 1 commit into
mainfrom
chore/bump-core-rename-returning
May 30, 2026
Merged

chore: bump waveflow-core rev + simplify rename handler#7
InstaZDLL merged 1 commit into
mainfrom
chore/bump-core-rename-returning

Conversation

@InstaZDLL

@InstaZDLL InstaZDLL commented May 30, 2026

Copy link
Copy Markdown
Owner

Summary

Picks up waveflow#184 which changed `PostgresProfileRepository::rename_for_user` from `bool` to `Option` via `UPDATE … RETURNING`. The handler's two-call dance (`rename_for_user` then `get_for_user`) collapses to one match: the updated row comes back in the same round-trip.

Diff at the call site

```

  • Ok(true) → get_for_user → Some(profile) | None (race 404) | Err
  • Ok(false) → 404
  • Err → 500
    ```

becomes

```

  • Ok(Some(profile)) → 200 + body
  • Ok(None) → 404
  • Err → 500
    ```

The false-404 window a concurrent DELETE could open between our UPDATE and the read-back is gone — both writes commit (or neither does) inside the same statement.

Rev: `24ffa58` → `bfb899b`

Test plan

  • `cargo check --all-targets`
  • `cargo fmt --all --check`
  • `cargo clippy --all-targets --all-features -- -D warnings`
  • CI Linux: full `cargo test` against the Postgres service — `update_renames_in_place` should still go green with the new shape.

Signed-off-by: InstaZDLL github.105mh@8shield.net

Pick up waveflow#184 (rename_for_user returns Option<Profile> via
UPDATE … RETURNING) and drop the post-rename get_for_user that used
to chase the bool. The handler is now:

    Ok(Some(profile)) → 200 + body
    Ok(None)          → 404
    Err               → 500 (log)

Three branches collapse to three branches that all do the right thing
without the rare false-404 race a concurrent DELETE used to be able to
trigger between the UPDATE and the read-back.

Rev: 24ffa58 → bfb899b
Signed-off-by: InstaZDLL <github.105mh@8shield.net>
@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (5)
  • chore: bump
  • chore(main): release
  • release-please
  • dependabot
  • [bot]

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b32779e3-5fe4-4861-928e-dc8804b4ad72

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-core-rename-returning

Comment @coderabbitai help to get the list of available commands and usage tips.

@InstaZDLL InstaZDLL self-assigned this May 30, 2026
@InstaZDLL
InstaZDLL merged commit 19c8f78 into main May 30, 2026
8 checks passed
@InstaZDLL
InstaZDLL deleted the chore/bump-core-rename-returning branch May 30, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant