chore: bump waveflow-core rev + simplify rename handler - #7
Merged
Conversation
Pick up waveflow#184 (rename_for_user returns Option<Profile> via
UPDATE … RETURNING) and drop the post-rename get_for_user that used
to chase the bool. The handler is now:
Ok(Some(profile)) → 200 + body
Ok(None) → 404
Err → 500 (log)
Three branches collapse to three branches that all do the right thing
without the rare false-404 race a concurrent DELETE used to be able to
trigger between the UPDATE and the read-back.
Rev: 24ffa58 → bfb899b
Signed-off-by: InstaZDLL <github.105mh@8shield.net>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (5)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up waveflow#184 which changed `PostgresProfileRepository::rename_for_user` from `bool` to `Option` via `UPDATE … RETURNING`. The handler's two-call dance (`rename_for_user` then `get_for_user`) collapses to one match: the updated row comes back in the same round-trip.
Diff at the call site
```
```
becomes
```
```
The false-404 window a concurrent DELETE could open between our UPDATE and the read-back is gone — both writes commit (or neither does) inside the same statement.
Rev: `24ffa58` → `bfb899b`
Test plan
Signed-off-by: InstaZDLL github.105mh@8shield.net