chore(auth): pause sign-up + sign-in for 1.5.0 - #67
Conversation
The desktop 1.5.0 release ships with multi-device sync deferred (see WaveFlow PR `chore/defer-sync-to-1.6.0`). With no desktop client able to bind, the web account creation + login flow has nothing to point at. Replace both forms with paused-account notices so anyone landing on /sign-up or /sign-in via a bookmark sees an honest "coming with 1.6.0" message instead of a Better-Auth form whose successful submit then dead-ends. - `sign-up.tsx`: replace the form (name + email + password + OAuth divider) with a notice + Back-to-home link. No call to `authClient.signUp.email()`, no provider availability loader (the desktop OAuth-loopback handshake is paused so we don't need the OAuth buttons either). - `sign-in.tsx`: replace the form with the same notice shape. KEEP the `safeContinueTarget` open-redirect gate as an exported function — its tests in `-sign-in.test.ts` still pass, locking the hardened path-prefix + origin-equality invariants for the 1.6.0 restoration. The route's `validateSearch` still accepts `?continue=...` so a stale desktop loopback URL doesn't 404. - `sign-up.test.tsx`: form-validation suite replaced with a single test asserting the paused notice renders + the form fields are absent. The original 8 cases come back with the form. Verification: `bun run typecheck` clean + `bun run test` 230/230 (vs 230/230 on main before — the sign-up suite count drops 7, picked up by the gate tests staying intact).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughLes routes ChangesMise en pause des routes d'authentification
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Companion to InstaZDLL/WaveFlow#262 which defers multi-device sync to 1.6.0. With no desktop client able to bind, the web account creation + login flow has nothing to point at. Replace both forms with paused-account notices so anyone landing on
/sign-upor/sign-invia bookmark or stale desktop OAuth-loopback URL sees an honest "coming with 1.6.0" message instead of a Better-Auth form whose successful submit dead-ends.What changes
sign-up.tsx— form (name + email + password + OAuth divider) replaced with a notice + Back-to-home link. No call toauthClient.signUp.email(), no provider availability loader.sign-in.tsx— same notice shape. KeepsafeContinueTargetexported — the open-redirect gate's tests in-sign-in.test.tsstill pass, locking the hardened path-prefix + origin-equality invariants for the 1.6.0 restoration. The route'svalidateSearchstill accepts?continue=...so a stale desktop loopback URL doesn't 404.sign-up.test.tsx— form-validation suite (8 cases) replaced with a single test asserting the paused notice renders + the form fields are absent. The original cases come back with the form.Verification
bun run typecheckcleanbun run test230/230 pass (vs 230/230 on main —safeContinueTargettest count holds; sign-up suite drops from 8 to 1, picked up by gate tests staying intact)Test plan
/sign-up— see paused notice + Back-to-home link/sign-in— see paused notice/sign-in?continue=/desktop-login?cb=...— page still renders (validateSearch still accepts the param) but no form appearsSummary by CodeRabbit
Notes de Sortie