COMP: Rename test names that collide with ITK core tests#56
Merged
Conversation
itkGradientMagnitudeImageFilterTest1 and itkCannyEdgeDetectionImageFilterTest2 are already registered by ITK's ImageGradient and ImageFeature modules, so a build with this remote module enabled emits AUTHOR_WARNINGs from itk_add_test and the two tests share ITK's Cleanup_<name> fixture, which races under ctest -j. Prefix both with the module name to make them unique. Only the ctest test name changes; the executables, arguments, and baseline files are unchanged.
hjmjohnson
marked this pull request as ready for review
July 18, 2026 20:54
hjmjohnson
commented
Jul 18, 2026
hjmjohnson
left a comment
Member
Author
There was a problem hiding this comment.
Just a test name change to remove conflicts with core ITK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the two test names that collide with ITK core tests, which ITK's nightly dashboards report as
AUTHOR_WARNINGs whenever this module is enabled.Beyond the warning noise, duplicate test names share ITK's
Cleanup_<name>fixture, so the colliding tests race underctest -j.The collision
itk_add_testkeeps a global registry of test names (CMake/ITKModuleTest.cmake). Two names here are already registered by ITK core:itkGradientMagnitudeImageFilterTest1Modules/Filtering/ImageGradient/test/CMakeLists.txtitkCannyEdgeDetectionImageFilterTest2Modules/Filtering/ImageFeature/test/CMakeLists.txtITK warns rather than fails for remote-module collisions, because they cannot be fixed in the ITK tree:
Observed on the ITK nightly
Linux-Ubuntu-GCC-Doxygen(blaster.kitware), https://open.cdash.org/builds/11424939/configure — 2 warnings, both from this module. No other module in that build produces any.The module's other ~48 test names are unique and unchanged.
Verification
Full ITK configure with
-DModule_LesionSizingToolkit=ON, same source tree and build directory for both runs:Duplicate test namewarningsResulting ctest registrations — four distinct tests where there were two collisions:
Scope of the change: only the
NAMEargument of twoitk_add_testcalls. The executables, arguments,--comparebaselines, and the.mhaoutput filenames are untouched, and neither old name is referenced anywhere else in this repository.Landing this does not by itself clear the dashboard warnings — ITK pins this module by commit in
Modules/Remote/LesionSizingToolkit.remote.cmake(currentlyaffbf7b0958205e2aab388bf0c3b7b1d5b0089de), so that pin needs bumping in a follow-up ITK change once this merges.