refactor: multiprocessing helper#222
Draft
NguyenHoangSon96 wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 78.90% 87.12% +8.22%
==========================================
Files 36 28 -8
Lines 2607 2082 -525
==========================================
- Hits 2057 1814 -243
+ Misses 550 268 -282 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
karel-rehor
reviewed
Jul 15, 2026
| bucket=self.database, | ||
| record=f"{measurement},tag=a value=\"number{x}\" {time.time_ns()}" | ||
| ) | ||
| writer.__del__() |
Contributor
There was a problem hiding this comment.
Please don't forget that ideally __del__() should not be called directly, and that instead a with block should be used here.
https://github.com/InfluxCommunity/influxdb3-python/pull/217/changes#r3507988624
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
Briefly describe your proposed changes:
Checklist